Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child diff simplify check - compare delete and content first #845

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

nopcoder
Copy link
Contributor

No description provided.

@nopcoder nopcoder requested a review from tzahij October 19, 2020 19:07
@nopcoder nopcoder self-assigned this Oct 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #845 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #845   +/-   ##
=======================================
  Coverage   43.11%   43.12%           
=======================================
  Files         136      136           
  Lines       10648    10640    -8     
=======================================
- Hits         4591     4588    -3     
+ Misses       5460     5456    -4     
+ Partials      597      596    -1     
Impacted Files Coverage Δ
catalog/cataloger_diff.go 68.21% <100.00%> (+1.54%) ⬆️
catalog/cataloger_create_repository.go 65.38% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d312bce...c614bc0. Read the comment docs.

Copy link
Contributor

@tzahij tzahij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@nopcoder nopcoder merged commit 6c6351b into master Oct 21, 2020
@nopcoder nopcoder deleted the chore/diff-checks branch October 21, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants