Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasklist extra #217

Closed
wants to merge 2 commits into from
Closed

Add tasklist extra #217

wants to merge 2 commits into from

Conversation

liguangsheng
Copy link
Contributor

Add tasklist extra

See Issue #216

@nicholasserra
Copy link
Collaborator

Thanks for the PR :)

Looks like this is failing a bunch of tests. Run make testone on your machine to run the test suite. We also only accept patches with test coverage. Please reference other PRs to see an example of a test being added.

@nicholasserra
Copy link
Collaborator

Replaced with #218

@cosven
Copy link
Contributor

cosven commented Feb 9, 2017

Thanks for the contribution for the task_list extra, but I have different thoughts on the task-list-wrapper-text.

Currently, the task-list-wrapper-text is:
_task_list_warpper_str = r'<p><input type="checkbox" class="task-list-item-checkbox" %sdisabled>%s</p>'. In my opinion, the <p> tag is unnecessary.

I think the better option will be:
<input type="checkbox" class="task-list-item-checkbox" disabled>%s, as github also handles in this way.

I also have a simple comment on that PR: https://github.com/trentm/python-markdown2/pull/218/files#r100302342

@liguangsheng @nicholasserra

@cosven
Copy link
Contributor

cosven commented Feb 9, 2017

I add a PR here: #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants