added tasklist extra and unit test #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you :D |
cosven
reviewed
Feb 9, 2017
| (.*) # list item text = \2 | ||
| ''', re.M | re.X | re.S) | ||
|
|
||
| _task_list_warpper_str = r'<p><input type="checkbox" class="task-list-item-checkbox" %sdisabled>%s</p>' |
There was a problem hiding this comment.
In my opinion, the <p> tag is unnecessary.
We can also have a look at github flavour markdown parser result
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" checked="" disabled=""> text body </li>
| def _task_list_item_sub(self, match): | ||
| marker = match.group(1) | ||
| item_text = match.group(2) | ||
| if marker == '[x]': |
There was a problem hiding this comment.
I believe we should also take into account the situation where an uppercase X is used since Github markdown also accepts that.
For e.g.
- this is marked
- this is also marked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tasklist extra and unit test.
See Issue #216