New checks UI #1253
Merged
New checks UI #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO
|
dottorblaster
force-pushed
the
new-checks-ui
branch
2 times, most recently
from
9c8b750 to
7ea9b29
Compare
nelsonkopliku
force-pushed
the
new-checks-ui
branch
3 times, most recently
from
9b3775a to
40e7a70
Compare
|
@dottorblaster banner action point addressed here #1371 |
nelsonkopliku
force-pushed
the
new-checks-ui
branch
from
430f29c to
c74bcfa
Compare
* Add an ExecutionHeader component * Add a selector to get hostnames of a given cluster * Refactor ExecutionResults to a Check based visualization
* Fix storybook configuration with @static alias * Add object tree factory * Add ObjectTree React component * Add tests * Add react-accessible-treeview and a webpack plugin required for Storybook * Add desctructuredArrayIgnorePattern option to eslint * Address review comments
* Enhance NotificationBox to support straight message text or a list of messages to show * Improve error handling on checks results page * Keep a loading box while the execution is running
…ts view (#1256) * Open remediation modal when checkId is clicked
* Add a getCheckExpectations utility to support check based view * Improve CheckResultOutline to properly handle more scenarios * Adjust ExecutionResults component so that it provides catalog expectations to a Check result outline * Address review comments * Adjust styling
* Chore: Use getClusterHostNames in ExecutionResultsPage * Make TargetResult clickable * Navigate to CheckDetail page when clicking on a target result row * Add an ExecutionContainer component that wraps loading states * Add a CheckResultInfoBox component that gives information about a check's execution context * Add a CheckDetailHeader that provides the introductory section of a check detail page * Add an initial version of the CheckResultDetail * Add a CheckResultDetailPage as a container interacting with the state * Wire up the newly created CheckResultDetailPage to the app router * Improve component testing * Improve selection for ExecutionResultsPage and CheckResultDetailPage * Rename getLastExecutionContext selector to getLastExecutionData * Improve loading effects
…1268) * Chore: cleanup CheckResultInfoBox classname * Add a getClusterHosts to get all the hosts of a cluster * Use getClusterHosts in getLastExecutionData selector * Adjust test factories in relation to hosts * Refactor ExecutionResults to use the provided cluster hosts * Refactor CheckResultDetailPage to use provided cluster hosts and pass those to the check detail
* Add empty state component and test
* Chore: extract and test transformation functions from CheckResultOutline * Implement a Check detail for a Host target * Determine the target id based on target type in CheckResultDetailPage * Split CheckResultDetail subcomponents in dedicated files * Address review feedbacks * Improve naming
* Add PremiumPill to ExecutionResults component
* Add an HealthIcon to CheckDetailHeader * Centralize enrichment of execution data agents check results with hostnames into selector * Cleanup extraction of expect_same statements results * Support both host and cluster wide ExpectationsResults * Add the ability to extract facts for cluster wide checks * Add support for both host and cluster wide facts to GatheredFacts component * Make CheckResultDetail support host and cluster wide checks * Address review feedbacks
* Display raw values for primitive types * Add FactValue tests and detail stories * Fix factories using transient params * Fix props in CheckResultDetail test
* Move provider filter to the right in catalog view * Add ProviderLabel storybook story * Update providerSelection and add story * Use the update ProviderSelection in catalog * Handle All entry in provider selection * Remove unwanted comments * Use all providers in ProviderSelection story * Refacto buildUpdateCatalogAction function
* Refactor NotFound component, add test and story * Add url error handling for CheckResultDetailPage
* Add an Accordion Component * Refactor ChecksCatalog to have collapsible groups * Adjust cypress test to select correct item in the DOM * Refactor CheckItem to use the new Accordion component * Refactor ChecksSelectionGroup to use the new Accordion component * Adjust z-index for ProviderSelection
* Refactor providerWarningBanners to also support result specific banners and expose retrieving functions * Use the banner retrieving functions * Refactor warning banners usage
nelsonkopliku
force-pushed
the
new-checks-ui
branch
from
c74bcfa to
cfa8fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a draft to keep an eye on the changes against main 😅