Open remediation modal when check id is clicked in the ExecutionResults view #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
added
enhancement
EMaksy
requested review from
dottorblaster,
fabriziosestito,
nelsonkopliku and
arbulu89
EMaksy
force-pushed
the
remediation_modal_on_check_id_click
branch
from
64ea2a0 to
cf5b120
Compare
EMaksy
force-pushed
the
remediation_modal_on_check_id_click
branch
from
cf5b120 to
f602cea
Compare
arbulu89
requested changes
Mar 14, 2023
assets/js/components/ExecutionResults/ExecutionResults.test.jsx
Outdated
Show resolved
Hide resolved
assets/js/components/ExecutionResults/ExecutionResults.test.jsx
Outdated
Show resolved
Hide resolved
assets/js/components/ExecutionResults/ExecutionResults.test.jsx
Outdated
Show resolved
Hide resolved
assets/js/components/ExecutionResults/ExecutionResults.test.jsx
Outdated
Show resolved
Hide resolved
dottorblaster
requested changes
Mar 14, 2023
EMaksy
force-pushed
the
remediation_modal_on_check_id_click
branch
2 times, most recently
from
65c587c to
0efbed7
Compare
EMaksy
force-pushed
the
remediation_modal_on_check_id_click
branch
from
0efbed7 to
802c193
Compare
arbulu89
approved these changes
Mar 15, 2023
nelsonkopliku
approved these changes
Mar 15, 2023
dottorblaster
approved these changes
Mar 15, 2023
dottorblaster
pushed a commit
that referenced
this pull request
Apr 5, 2023
…ts view (#1256) * Open remediation modal when checkId is clicked
dottorblaster
pushed a commit
that referenced
this pull request
Apr 5, 2023
…ts view (#1256) * Open remediation modal when checkId is clicked
nelsonkopliku
pushed a commit
that referenced
this pull request
Apr 26, 2023
…ts view (#1256) * Open remediation modal when checkId is clicked
nelsonkopliku
pushed a commit
that referenced
this pull request
Apr 26, 2023
…ts view (#1256) * Open remediation modal when checkId is clicked
nelsonkopliku
pushed a commit
that referenced
this pull request
Apr 27, 2023
…ts view (#1256) * Open remediation modal when checkId is clicked
nelsonkopliku
pushed a commit
that referenced
this pull request
May 4, 2023
…ts view (#1256) * Open remediation modal when checkId is clicked
nelsonkopliku
pushed a commit
that referenced
this pull request
May 4, 2023
…ts view (#1256) * Open remediation modal when checkId is clicked
nelsonkopliku
added a commit
that referenced
this pull request
May 4, 2023
* Check based execution results (#1223) * Add an ExecutionHeader component * Add a selector to get hostnames of a given cluster * Refactor ExecutionResults to a Check based visualization * Object tree component (#1228) * Fix storybook configuration with @static alias * Add object tree factory * Add ObjectTree React component * Add tests * Add react-accessible-treeview and a webpack plugin required for Storybook * Add desctructuredArrayIgnorePattern option to eslint * Address review comments * Add WIP * Re-add checks filtering (#1231) * Remove debug code (#1235) * Improve error handling on checks results page (#1232) * Enhance NotificationBox to support straight message text or a list of messages to show * Improve error handling on checks results page * Keep a loading box while the execution is running * Fix ExecutionHeader test with new warning text * Open remediation modal when check id is clicked in the ExecutionResults view (#1256) * Open remediation modal when checkId is clicked * Fix determining expectations results (#1246) * Add a getCheckExpectations utility to support check based view * Improve CheckResultOutline to properly handle more scenarios * Adjust ExecutionResults component so that it provides catalog expectations to a Check result outline * Address review comments * Adjust styling * Check result detail pt1 (#1248) * Chore: Use getClusterHostNames in ExecutionResultsPage * Make TargetResult clickable * Navigate to CheckDetail page when clicking on a target result row * Add an ExecutionContainer component that wraps loading states * Add a CheckResultInfoBox component that gives information about a check's execution context * Add a CheckDetailHeader that provides the introductory section of a check detail page * Add an initial version of the CheckResultDetail * Add a CheckResultDetailPage as a container interacting with the state * Wire up the newly created CheckResultDetailPage to the app router * Improve component testing * Improve selection for ExecutionResultsPage and CheckResultDetailPage * Rename getLastExecutionContext selector to getLastExecutionData * Improve loading effects * Improve cluster hosts retrieval for execution results/check detail (#1268) * Chore: cleanup CheckResultInfoBox classname * Add a getClusterHosts to get all the hosts of a cluster * Use getClusterHosts in getLastExecutionData selector * Adjust test factories in relation to hosts * Refactor ExecutionResults to use the provided cluster hosts * Refactor CheckResultDetailPage to use provided cluster hosts and pass those to the check detail * Add empty state subcomponent for the table component (#1279) * Add empty state component and test * Check Result Detail pt2 (#1264) * Chore: extract and test transformation functions from CheckResultOutline * Implement a Check detail for a Host target * Determine the target id based on target type in CheckResultDetailPage * Split CheckResultDetail subcomponents in dedicated files * Address review feedbacks * Improve naming * Visually identify premium checks in the ExecutionResults view (#1293) * Add PremiumPill to ExecutionResults component * Cluster wide Check Result Detail (#1291) * Add an HealthIcon to CheckDetailHeader * Centralize enrichment of execution data agents check results with hostnames into selector * Cleanup extraction of expect_same statements results * Support both host and cluster wide ExpectationsResults * Add the ability to extract facts for cluster wide checks * Add support for both host and cluster wide facts to GatheredFacts component * Make CheckResultDetail support host and cluster wide checks * Address review feedbacks * Fact value primitive types (#1317) * Display raw values for primitive types * Add FactValue tests and detail stories * Fix factories using transient params * Fix props in CheckResultDetail test * Add some margin between cluster-wide facts (#1336) * Clean up legacy code (#1325) * Catalog provider filter (#1363) * Move provider filter to the right in catalog view * Add ProviderLabel storybook story * Update providerSelection and add story * Use the update ProviderSelection in catalog * Handle All entry in provider selection * Remove unwanted comments * Use all providers in ProviderSelection story * Refacto buildUpdateCatalogAction function * Add url error handling for the CheckResultDetailPage (#1364) * Refactor NotFound component, add test and story * Add url error handling for CheckResultDetailPage * Collapsible checks catalog (#1369) * Add an Accordion Component * Refactor ChecksCatalog to have collapsible groups * Adjust cypress test to select correct item in the DOM * Refactor CheckItem to use the new Accordion component * Refactor ChecksSelectionGroup to use the new Accordion component * Adjust z-index for ProviderSelection * Warning banner improvement (#1371) * Refactor providerWarningBanners to also support result specific banners and expose retrieving functions * Use the banner retrieving functions * Refactor warning banners usage --------- Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com> Co-authored-by: EMaksy <emaksymenko@suse.com> Co-authored-by: Xabier Arbulu Insausti <xarbulu@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new feature to the ExecutionResults view, where clicking on the check ID will now open the remediation modal
The modal will not open if the user clicks outside the check ID but inside the same row, preventing unintended opening of the modal.
remediationModalOnClick.webm
How was this tested?
A test to check if the remediation modal opens when clicking on the check ID.
A test to check if the remediation modal does not open when clicking outside the check ID but within the same row.