Enforce expectation names uniqueness in CheckResultOutline test #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
chore
javascript
EMaksy
approved these changes
Jun 20, 2023
dottorblaster
approved these changes
Jun 20, 2023
nelsonkopliku
force-pushed
the
enforce-unique-expectation-names-in-tests
branch
from
b08c9d2 to
9bdb891
Compare
nelsonkopliku
commented
Jun 20, 2023
| const expectationName3 = faker.color.human(); | ||
| const expectSameExpectationName1 = faker.lorem.word(); | ||
| const expectSameExpectationName2 = faker.lorem.word(); | ||
| const expectationName1 = faker.datatype.uuid(); |
There was a problem hiding this comment.
@dottorblaster I applied the suggested change about uuids.
I am afraid, though, that the should expectation names be uuids? doubt might rise, which is not the case.
As long as it clear that we just want strings that are unique in a restricted context and not necessarily uuids, we should be good.
There was a problem hiding this comment.
Yeah I agree, for me it's clear, I don't know if you want to leave a comment or something 😅
nelsonkopliku
force-pushed
the
enforce-unique-expectation-names-in-tests
branch
from
9bdb891 to
0e14eae
Compare
nelsonkopliku
force-pushed
the
enforce-unique-expectation-names-in-tests
branch
from
0e14eae to
6e8074a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should remove flakiness for the specific test changed.