Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce expectation names uniqueness in CheckResultOutline test #1549

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Enforce expectation names uniqueness in CheckResultOutline test #1549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions assets/js/components/ExecutionResults/CheckResultOutline.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,12 @@ describe('CheckResultOutline Component', () => {
const checkID = faker.datatype.uuid();
const clusterName = faker.lorem.word();

const expectationName1 = faker.company.name();
const expectationName2 = faker.color.human();
const expectationName3 = faker.color.human();
const expectSameExpectationName1 = faker.lorem.word();
const expectSameExpectationName2 = faker.lorem.word();
// expectation names are not required to be uuids. using uuids for their uniqueness.
const expectationName1 = faker.datatype.uuid();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dottorblaster I applied the suggested change about uuids.

I am afraid, though, that the should expectation names be uuids? doubt might rise, which is not the case.

As long as it clear that we just want strings that are unique in a restricted context and not necessarily uuids, we should be good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, for me it's clear, I don't know if you want to leave a comment or something 😅

const expectationName2 = faker.datatype.uuid();
const expectationName3 = faker.datatype.uuid();
const expectSameExpectationName1 = faker.datatype.uuid();
const expectSameExpectationName2 = faker.datatype.uuid();

const expectations = [
catalogExpectExpectationFactory.build({
Expand Down