Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host checks execution frontend #1753

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Host checks execution frontend #1753

merged 6 commits into from
Aug 29, 2023

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Aug 25, 2023

Description

This PR will enable the host checks execution in the UI

Demo

demo_checks_execution

How was this tested?

Added automated tests

@EMaksy EMaksy added enhancement New feature or request javascript Pull requests that update Javascript code env Create an ephimeral environment for the pr branch labels Aug 25, 2023
@EMaksy EMaksy self-assigned this Aug 25, 2023
@EMaksy EMaksy force-pushed the host_checks_execution_frontend branch 3 times, most recently from 673b28e to 47d5510 Compare August 25, 2023 15:46
@EMaksy EMaksy force-pushed the host_checks_execution_frontend branch 4 times, most recently from 7b67b9a to d53a97e Compare August 28, 2023 08:24
@EMaksy EMaksy marked this pull request as ready for review August 28, 2023 09:04
@EMaksy EMaksy force-pushed the host_checks_execution_frontend branch 2 times, most recently from 0bbb1cb to 46eff3c Compare August 28, 2023 13:20
dottorblaster
dottorblaster suggested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny thing then we can merge I guess

assets/js/components/HostDetails/HostChecksSelection.jsx Outdated Show resolved Hide resolved
assets/js/components/HostDetails/HostChecksSelection.jsx Outdated Show resolved Hide resolved
@EMaksy EMaksy force-pushed the host_checks_execution_frontend branch 3 times, most recently from 82e3f23 to cb4ca76 Compare August 29, 2023 10:11
@EMaksy EMaksy requested a review from dottorblaster August 29, 2023 10:27
nelsonkopliku
nelsonkopliku reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this we need to get both wanda and the api merged.

assets/js/lib/api/checks.js Outdated Show resolved Hide resolved
assets/js/state/actions/lastExecutions.js Show resolved Hide resolved
dottorblaster
dottorblaster approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMaksy EMaksy force-pushed the host_checks_execution_frontend branch 2 times, most recently from 2577981 to 5f22d0f Compare August 29, 2023 14:48
@EMaksy EMaksy force-pushed the host_checks_execution_frontend branch 2 times, most recently from 4f2d409 to a8c2e7c Compare August 29, 2023 15:01
@EMaksy EMaksy merged commit a1925d1 into main Aug 29, 2023
@EMaksy EMaksy deleted the host_checks_execution_frontend branch August 29, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

Assignees

@EMaksy EMaksy

Labels
enhancement New feature or request env Create an ephimeral environment for the pr branch javascript Pull requests that update Javascript code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EMaksy @dottorblaster @nelsonkopliku