Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js to version 20.14.0 LTS #2660

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Upgrade Node.js to version 20.14.0 LTS #2660

merged 3 commits into from
Jul 1, 2024

Conversation

janvhs
Copy link
Member

@janvhs janvhs commented May 29, 2024

This commit upgrade the Node.js version to 20.14.0.

I am running this for several weeks on my MacBook Air M2 and it works without any problems. This will allow us to upgrade Storybook and ESLint, once all our ESLint plugins are compatible with ESLint 9.

How was this tested?

Building booth the Dockerfile in the root, and in packaging with Podman and running frontend tests.
I did not try asdf, since I don't have that installed. However, I am sure it will accept the version.

@janvhs janvhs added documentation Improvements or additions to documentation tech debt chore dependencies Pull requests that update a dependency file labels May 29, 2024
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we lift the merge freeze just rebase this on main and we can merge 👍

janvhs added 3 commits July 1, 2024 17:03
This commit upgrade the Node.js version to 20.14.0.

I am running this for several weeks on my MacBook Air M2 and it works
without any problems. This will allow us to upgrade Sotorybook and
ESLint, once all our ESLint plugins are compatible with ESLint 9.
This brings the CI up to the same version used in the development and
release environment.
This commit replaces the npm version for the RPM, to use node v20's
version of npm.
@janvhs janvhs merged commit 95def23 into main Jul 1, 2024
26 checks passed
@janvhs janvhs deleted the node-20 branch July 1, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation tech debt
Development

Successfully merging this pull request may close these issues.

2 participants