Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js to version 20.14.0 LTS #2660

Merged
merged 3 commits into from
Jul 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

env:
MIX_ENV: test
NODE_VERSION: "16"
NODE_VERSION: "20"
MANTAINERS: '["cdimonaco", "dottorblaster", "janvhs", "rtorrero", "nelsonkopliku", "arbulu89","jagabomb","emaksy","jamie-suse"]'
RG_TEST_LABEL: regression

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: "16"
node-version: "20"
cache: "npm"
cache-dependency-path: test/e2e/package-lock.json
- name: Checkout terraform repo
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
elixir 1.15.7-otp-26
erlang 26.2.1
nodejs 16.16.0
nodejs 20.14.0
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ARG MIX_ENV=prod
ENV MIX_ENV=$MIX_ENV
RUN mix deps.get

FROM registry.suse.com/bci/nodejs:16 AS assets-build
FROM registry.suse.com/bci/nodejs:20 AS assets-build
COPY --from=elixir-build /build /build
WORKDIR /build/assets
RUN npm install
Expand Down
2 changes: 1 addition & 1 deletion guides/development/hack_on_the_trento.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ In order to run the Trento Web application, the following software must be insta

1. [Elixir](https://elixir-lang.org/) - 1.15.7 preferred
2. [Erlang OTP](https://www.erlang.org/) - 26.1.2 preferred
3. [Node.js](https://nodejs.org/en/) - 16.16.0 preferred
3. [Node.js](https://nodejs.org/en/) - 20.14.0 preferred
4. [Docker](https://docs.docker.com/get-docker/)
5. [Docker Compose](https://docs.docker.com/compose/install/)

Expand Down
2 changes: 1 addition & 1 deletion packaging/suse/container/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#!UseOBSRepositories
#!ExclusiveArch: x86_64

FROM bci/nodejs:16 AS assets-build
FROM bci/nodejs:20 AS assets-build
ADD web.tar.gz /build/
WORKDIR /build/web/assets
RUN npm run tailwind:build
Expand Down
4 changes: 2 additions & 2 deletions packaging/suse/rpm/trento-web.spec
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Source2: package-lock.json
Source3: node_modules.spec.inc
%include %{_sourcedir}/node_modules.spec.inc
Group: System/Monitoring
BuildRequires: elixir >= 1.15, elixir-hex, npm16, erlang-rebar3, git-core, local-npm-registry, make, gcc
BuildRequires: elixir >= 1.15, elixir-hex, npm20, erlang-rebar3, git-core, local-npm-registry, make, gcc

%description
Trento is an open cloud-native web application for SAP Applications administrators.
Expand Down Expand Up @@ -83,4 +83,4 @@ install -D -m 0600 packaging/suse/rpm/systemd/trento-web.example %{buildroot}/et
%license LICENSE
%doc README.md guides

%changelog
%changelog