Skip to content

Commit

Permalink
ALWAYS cache benchmark generated data.
Browse files Browse the repository at this point in the history
  • Loading branch information
trexfeathers committed Jan 5, 2022
1 parent 83eef27 commit 94aff73
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
IRIS_TEST_DATA_VERSION: "2.5"
# Lets us manually bump the cache to rebuild
TEST_DATA_CACHE_BUILD: "2"
GEN_DATA_CACHE_BUILD: "1"
PY_VER: 3.8

steps:
Expand Down Expand Up @@ -54,8 +53,13 @@ jobs:
with:
path: |
${{ env.IRIS_TEST_DATA_PATH }}
key:
test-data-${{ env.IRIS_TEST_DATA_VERSION }}-${{ env.TEST_DATA_CACHE_BUILD }}
# Make sure GHA never gets an exact cache match by using the unique
# github.sha. This means it will always store this run as a new
# cache (any changes happen DURING the run, and I don't _think_ GHA
# caching has anything native to support this). Cache restoration
# still succeeds via the partial restore-key match.
key: ${{ runner.os }}-${{ github.sha }}
restore-keys: ${{ runner.os }}

- name: Cache generated data directory
id: cache-generated-data
Expand Down

0 comments on commit 94aff73

Please sign in to comment.