-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix title patterns that use procs are not supported #21
Conversation
This commit makes the module compatible with `puppet generate types`. Environment isolation is *really* important for a module where types are having new parameters added on a regular basis. See https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 puppetlabs/puppetlabs-java_ks#169 voxpupuli/puppet-wildfly#227
I've tested this and here is a sample of one of the .resource_types files
|
@alexjfisher Thanks for the contribution. I was not aware of the environment isolation features but should solve several problems I've had with type properties changing and causing issues until puppetserver restarted. Now the task of updating other's modules with this similar change. |
Currently the title patterns with proc prevent `puppet generate types` from working: Error: /etc/puppetlabs/code/environments/production/modules/openldap/lib/puppet/type/openldap_access.rb: title patterns that use procs are not supported. Error: /etc/puppetlabs/code/environments/production/modules/openldap/lib/puppet/type/openldap_dbindex.rb: title patterns that use procs are not supported. Error: /etc/puppetlabs/code/environments/production/modules/openldap/lib/puppet/type/openldap_overlay.rb: title patterns that use procs are not supported. https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21
This will allow `puppet generate types` to function Example: Error: /etc/puppetlabs/code/environments/production/modules/splunk/lib/puppet/type/splunk_alert_actions.rb: title patterns that use procs are not supported. https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21
This will resolve errors with `puppet generate types` Example: ``` Error: /etc/puppetlabs/code/environments/production/modules/augeasproviders_shellvar/lib/puppet/type/shellvar.rb: title patterns that use procs are not supported. ``` https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21
This change will allow `puppet generate types` to function Error: ``` Error: /etc/puppetlabs/code/environments/production/modules/windows_env/lib/puppet/type/windows_env.rb: title patterns that use procs are not supported. ``` https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21
This change will allow `puppet generate types` to function Error: ``` Error: /etc/puppetlabs/code/environments/production/modules/windows_env/lib/puppet/type/windows_env.rb: title patterns that use procs are not supported. ``` https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21
This change will allow `puppet generate types` to function Error: ``` Error: /etc/puppetlabs/code/environments/production/modules/windows_env/lib/puppet/type/windows_env.rb: title patterns that use procs are not supported. ``` https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21
In some cases even restarting the puppetserver wasn't enough. If not all environments have the same version of the module, it's luck of the draw as to which version gets loaded first.
|
* Fix title patterns to not use unsupported proc This will resolve errors with `puppet generate types` Example: ``` Error: /etc/puppetlabs/code/environments/production/modules/augeasproviders_shellvar/lib/puppet/type/shellvar.rb: title patterns that use procs are not supported. ``` https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21 Closes #27 Closes #26
This will allow `puppet generate types` to function Example: Error: /etc/puppetlabs/code/environments/production/modules/splunk/lib/puppet/type/splunk_alert_actions.rb: title patterns that use procs are not supported. https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416 treydock/puppet-module-keycloak#21
This commit makes the module compatible with
puppet generate types
.Environment isolation is really important for a module where types
are having new parameters added on a regular basis.
See
https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416
puppetlabs/puppetlabs-java_ks#169
voxpupuli/puppet-wildfly#227