Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported use of proc in title patterns #174

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

treydock
Copy link
Contributor

This will allow puppet generate types to function

Example:

Error: /etc/puppetlabs/code/environments/production/modules/splunk/lib/puppet/type/splunk_alert_actions.rb: title patterns that use procs are not supported.

https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416
treydock/puppet-module-keycloak#21

This will allow `puppet generate types` to function

Example:
Error: /etc/puppetlabs/code/environments/production/modules/splunk/lib/puppet/type/splunk_alert_actions.rb: title patterns that use procs are not supported.

https://tickets.puppetlabs.com/browse/MODULES-4505?focusedCommentId=418416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-418416
treydock/puppet-module-keycloak#21
@alexjfisher
Copy link
Member

I had to look up the ->(x) notation here. This looks correct to me.

@alexjfisher
Copy link
Member

The build failures are still due to #169 I think.

@TraGicCode TraGicCode self-requested a review March 12, 2018 15:47
Copy link
Contributor

@TraGicCode TraGicCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :). Yes the existing failures will be there unfortunately until the above linked issue is resolved.

@TraGicCode TraGicCode merged commit c432062 into voxpupuli:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants