Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum bump fee #12168

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Ethereum bump fee #12168

merged 3 commits into from
Apr 30, 2024

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented Apr 26, 2024 •
edited
Loading

Description

  • added logic to identify EVM in blockbook, only EVMs have nonce, Bitcoin-like coin does not. Temporarily approved by @marekrjpolak even though noone likes it there is no other solution for now.
  • staking pool info moved to misc so that it is not there for all Blockbook coins
  • staking pool type moved to file "generated" by Blockbook
  • replaced deprecated erc20Contract by contractInfo, it is not used now but who knows, maybe one they it will find place in Warn about sending funds to a contract address #7244
  • added addressAliases, it will be useful for ENS resolver in Trezor Suite #8618. Good to see it in account to detect bugs. I already reported one to Martin

And now finally:

Related Issue

Fixes #8671

Screenshots:

Screenshot 2024-04-29 at 17 24 29

@tomasklim tomasklim force-pushed the fix/eth branch 3 times, most recently from 12d09c4 to ba114af Compare April 29, 2024 15:15
@tomasklim tomasklim marked this pull request as ready for review April 29, 2024 15:21
@tomasklim tomasklim added the release Will be included in the upcoming release. Needs to be backported to the release branch. label Apr 29, 2024
marekrjpolak
marekrjpolak approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomasklim tomasklim merged commit 28afd8a into develop Apr 30, 2024
67 of 70 checks passed
@tomasklim tomasklim deleted the fix/eth branch April 30, 2024 12:25
@tomasklim
Copy link
Member Author

Screenshot 2024-05-27 at 18 27 03
hups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekrjpolak marekrjpolak marekrjpolak approved these changes

@martykan martykan Awaiting requested review from martykan

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

Assignees
No one assigned
Labels
release Will be included in the upcoming release. Needs to be backported to the release branch.
Projects
No open projects
Suite Pull Requests
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to bump ETH fee when sending more than a half of balance
2 participants
@tomasklim @marekrjpolak