Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): Enhance HiddenPlaceholder using special font #13950

Closed
wants to merge 1 commit into from

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Aug 23, 2024

Discreet mode currently leaves numerical values blurred, but technically still possible to decypher.
Enhance it to actually replace every number with $, making them completely illegible.

🚧 PROOF OF CONCEPT 🚧

Description

  • JS approach has been tried in #13914 (complex, messy code, unreliable),
  • this time try it with only CSS using font-family.
  • special font was prepared using the free online tool Glyphr Studio
  • the font simply has ever digit replaced with $

Disadvantage: we still show number of digits..

ℹ️ I chose $ because it's narrower than # or &, but still it's not an ideal pick, you can see that the line height is higher, so all content expands down 🙈
Maybe I messed up something in Glyphr Studio, but idk, this is just PoC! I can later perfect it using * maybe?

Related Issue

Resolve #10567

Screenshots:

Video shows behavior with hover:

HiddenPlaceholder.with.special.font.webm

@Lemonexe Lemonexe force-pushed the feat/enhance-hidden-placeholder-v2 branch from e04636f to 7f904d7 Compare August 23, 2024 14:34
@Lemonexe
Copy link
Contributor Author

Closing, because creating the special font would be too much work if we want to look consistent (this was just a demo, kinda broken).
The font was created by an external partner, and we'd have to contract them again for it.

Will focus on JS solution.

@Lemonexe Lemonexe closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the "Hide balances" feature
1 participant