Update dotEnv.ts to ignore OTEL_EXPORTER_OTLP_ENDPOINT as well

[iFlyinq]

Closes #

✅ Checklist

• I have followed every step in the contributing guide
• The PR title follows the convention.
• I ran and tested the code works

---

Problem:

In my NextJS application I have a OTEL_EXPORTER_OTLP_ENDPOINT env variable and it is synced to the task runner as well. Which means, it overrides the trigger webapp otel endpoint. Maybe it should ignore this specific env variable since it kinda fucks up all telemetry, or optionally add another env var like you did for the DEV_OTEL_EXPORTER_OTLP_ENDPOINT like TRIGGER_OTEL_EXPORTER_OTLP_ENDPOINT/PROD_OTEL_EXPORTER_OTLP_ENDPOINT? Any suggestions on how I could handle this the best, or parhaps make a PR to get hands on this issue.

💯

Summary by CodeRabbit

• Bug Fixes
  • Removed the OTEL_EXPORTER_OTLP_ENDPOINT variable from resolved environment variables to enhance security and consistency in managing sensitive configurations.
  • Updated handling of environment variables to prevent user-supplied values from overwriting internal defaults, improving robustness in multi-configuration scenarios.

[changeset-bot]

🦋 Changeset detected

Latest commit: 36a47d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
trigger.dev	Patch
@trigger.dev/build	Patch
@trigger.dev/core	Patch
@trigger.dev/sdk	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1307

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1307

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1307

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1307

commit: 36a47d4

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the resolveDotEnvVars function in the dotEnv.ts file by removing the OTEL_EXPORTER_OTLP_ENDPOINT variable from the resolved environment variables. This adjustment is consistent with the existing logic that excludes other sensitive variables, enhancing the management of environment-specific configurations.

Changes

Files	Change Summary
packages/cli-v3/src/utilities/dotEnv.ts	Removed the OTEL_EXPORTER_OTLP_ENDPOINT variable from the result object in the resolveDotEnvVars function.

Possibly related PRs

• Update dotEnv.ts to ignore OTEL_EXPORTER_OTLP_ENDPOINT as well #1307: This PR directly modifies the resolveDotEnvVars function in dotEnv.ts to delete the OTEL_EXPORTER_OTLP_ENDPOINT variable, which is the same change made in the main PR, indicating a strong connection between the two.

Suggested reviewers

• ericallam

Poem

In the garden of code, where the variables play,
A rabbit hops in, clearing the way.
With a flick of a paw, the endpoint's now gone,
Keeping secrets safe, from dusk until dawn.
Hooray for the changes, so tidy and neat,
A cleaner environment, oh what a treat! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.