Skip to content

fix: Added dev.vars into dotEnv file #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

harshsbhat
Copy link
Contributor

@harshsbhat harshsbhat commented Sep 21, 2024

Closes #1338

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

[Describe the steps you took to test this change]


Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

Summary by CodeRabbit

  • New Features
    • Expanded configuration capabilities by adding support for a new environment variable file, "dev.vars".

This enhancement allows for greater flexibility in managing application settings.

Copy link

changeset-bot bot commented Sep 21, 2024

🦋 Changeset detected

Latest commit: 9b96f01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
trigger.dev Patch
@trigger.dev/build Patch
@trigger.dev/core Patch
@trigger.dev/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 21, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the ENVVAR_FILES constant in the dotEnv.ts file by adding the entry "dev.vars" to the existing array of environment variable files. This change enables the application to recognize and load an additional configuration file, thus improving its environment variable management capabilities.

Changes

File Change Summary
packages/cli-v3/src/utilities/dotEnv.ts Updated ENVVAR_FILES constant to include "dev.vars"

Assessment against linked issues

Objective Addressed Explanation
dev CLI should automatically load dev.vars file as an env var (#1338)

Possibly related PRs

Poem

In the meadow, where bunnies play,
A new file joins the fray today.
"dev.vars" hops in, oh what a sight,
Making our configs feel just right!
With each change, our tools grow bright,
Hooray for updates, a joyful delight! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ericallam
Copy link
Member

Looks good! Could you add a patch changeset?

@harshsbhat
Copy link
Contributor Author

Looks good! Could you add a patch changeset?

I have pushed the changes. I am unsure if I am correct as I have never done this before.

@ericallam ericallam merged commit 9ce3f79 into triggerdotdev:main Sep 21, 2024
6 of 7 checks passed
Copy link

pkg-pr-new bot commented Sep 21, 2024

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1340
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1340
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1340
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1340

commit: 9b96f01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev CLI should automatically load dev.vars file as an env var
2 participants