Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: sparser GeometricInterpolationP #6681

Closed
lucbv opened this issue Jan 29, 2020 · 1 comment
Closed

MueLu: sparser GeometricInterpolationP #6681

lucbv opened this issue Jan 29, 2020 · 1 comment
Assignees
@lucbv
Labels
pkg: MueLu type: enhancement Issue is an enhancement, not a bug

Comments

@lucbv
Copy link
Contributor

lucbv commented Jan 29, 2020

Enhancement

@trilinos/muelu @rstumin @mayrmt

Adding an option to the GeometricInterpolationPFactory that generates sparser prolongation operators by filtering out the interpolation coefficients below 1e-6.
This generates much sparser P, R and Ac matrices while retaining good interpolation accuracy since the total number of interpolation coefficients per row is caped at 8.
@lucbv lucbv added type: enhancement Issue is an enhancement, not a bug pkg: MueLu labels Jan 29, 2020
@lucbv lucbv self-assigned this Jan 29, 2020
lucbv added a commit to lucbv/Trilinos that referenced this issue Jan 29, 2020
@lucbv
MueLu: adding thresholding of the interpolation values in GeometricIn…
ff6894a 
…terpolationPFactory, see issue trilinos#6681

This is a first cut that performs reasonably well, the idea is to look at interpolation coefficient generated for each fine point.
If the coefficients are smaller than a given tolerance (1e-6), they are dropped.
This results in much sparser coarse grid as well as smaller P and R matrices.
If we want to keep this idea around we should rewritte the structured aggregation factory to obtain the correct graph directly instead of recomputing it in the prolongator factory.
@lucbv lucbv mentioned this issue Jan 29, 2020
Merged
trilinos-autotester added a commit that referenced this issue Jan 29, 2020
@trilinos-autotester
Merge Pull Request #6682 from lucbv/Trilinos/MueLu_geometric_squeeze
b71a183 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: MueLu: adding thresholding of the interpolation values in GeometricInterpolationPFactory, see issue #6681
PR Author: lucbv
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jan 30, 2020
Merge 'trilinos/Trilinos:develop' (b71a183) into 'tcad-charon/Trilino…
67f3ed3 
…s:develop' (2bfd2c7).

* trilinos-develop: (104 commits)
  MueLu: adding thresholding of the interpolation values in GeometricInterpolationPFactory, see issue trilinos#6681
  This turns off the Anasazi_Epetra_OrthoManagerGenTester_0_MPI_4 test
  Zoltan2: expose RCM root node options
  Zoltan2: use stable sort in RCM and AMD
  Belos: removed deprecated Belos::toString()
  Tacho - remove the word
  atdm ats2: Create /tmp/<userid>/ if it does not exist (CDOFA-72)
  ATDM 'ats2' fix names of builds to match SPARC builds (COFA-72)
  Fixups for atdm/ats2/environment.sh (CDOFA-72)
  Make default 'gnu' and 'cuda' builds (CDOFA-72)
  Add whitespace to improve readability (CDOFA-72)
  Add comment that we can't purge modules and why (CDOFA-72)
  ATDM: Implemented PR feedback
  Fix SuiteSparse paths when Trilinos is not CMAKE_PROJECT
  Remove duplicate include_directories
  Remove nonexistent include_directories
  Refactoring sidset construction to remove slow lookup calls.
  Muelu: Force to store the Filtering parameter as a bool as it is assumed to be a bool
  Stokhos: Update the Mask implementation to use mask_assign
  Fix deviation from C89
  ...
@lucbv
Copy link
Contributor Author

lucbv commented Jan 30, 2020

PR #6682 resolved this issue so I will close this

@lucbv lucbv closed this as completed Jan 30, 2020
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jan 31, 2020
Merge 'trilinos/Trilinos:develop' (45dca80) into 'tcad-charon/Trilino…
75a42c2 
…s:develop' (2bfd2c7).

* trilinos-develop: (111 commits)
  Moertel: fix warnings due to signed/unsigned comparison, see issue trilinos#6698
  Add clang-7.0.1 explicitly in parsing (ATDV-291)
  MueLu ParameterListInterpreter test: Remove and regenerate xml
  PyTrilinos: Update swig interface files for SWIG 4.0
  PyTrilinos: Update build system for SWIG 4.0
  PyTrilinos: Replace SWIGEMPTYHACK with PYTRILINOS_NULLSTR
  MueLu: adding thresholding of the interpolation values in GeometricInterpolationPFactory, see issue trilinos#6681
  Made default clang7, tested with openmp and empire
  This turns off the Anasazi_Epetra_OrthoManagerGenTester_0_MPI_4 test
  Zoltan2: expose RCM root node options
  Zoltan2: use stable sort in RCM and AMD
  Belos: removed deprecated Belos::toString()
  Tacho - remove the word
  atdm ats2: Create /tmp/<userid>/ if it does not exist (CDOFA-72)
  ATDM 'ats2' fix names of builds to match SPARC builds (COFA-72)
  Fixups for atdm/ats2/environment.sh (CDOFA-72)
  Make default 'gnu' and 'cuda' builds (CDOFA-72)
  Add whitespace to improve readability (CDOFA-72)
  Add comment that we can't purge modules and why (CDOFA-72)
  ATDM: Implemented PR feedback
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Feb 1, 2020
Merge 'trilinos/Trilinos:develop' (4cfa684) into 'tcad-charon/Trilino…
ed8eae8 
…s:develop' (2bfd2c7).

* trilinos-develop: (122 commits)
  Tpetra: fixing small typo
  Moertel: fix warnings due to signed/unsigned comparison, see issue trilinos#6698
  Incoprporating changes suggested in PR
  Tpetra: adding benchmark for CrsMatrix::apply, see issue trilinos#6692
  Add clang-7.0.1 explicitly in parsing (ATDV-291)
  Tpetra::CrsGraph: Fix build errors relating to unique_ptr
  MueLu ParameterListInterpreter test: Remove and regenerate xml
  Tpetra::CrsGraph::makeIndicesLocal: Add verbose output
  Tpetra::CrsMatrix::globalAssemble: Add verbose debugging output
  Tpetra::CrsMatrix::fillLocalMatrix: Add verbose output
  Tpetra::CrsMatrix::fillLocalGraphAndMatrix: Add verbose output
  Tpetra::CrsMatrix: Add more verbose output on allocation
  Tpetra: Add verbose debugging output to padCrsArrays
  PyTrilinos: Update swig interface files for SWIG 4.0
  PyTrilinos: Update build system for SWIG 4.0
  PyTrilinos: Replace SWIGEMPTYHACK with PYTRILINOS_NULLSTR
  Tpetra::Crs{Graph,Matrix}: Add verbose output for memory use
  MueLu: adding thresholding of the interpolation values in GeometricInterpolationPFactory, see issue trilinos#6681
  Made default clang7, tested with openmp and empire
  This turns off the Anasazi_Epetra_OrthoManagerGenTester_0_MPI_4 test
  ...
@trilinos-autotester trilinos-autotester mentioned this issue Feb 18, 2022
Merged
@jhux2 jhux2 added this to MueLu Aug 12, 2024
@jhux2 jhux2 moved this to Done in MueLu Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucbv lucbv

Labels
pkg: MueLu type: enhancement Issue is an enhancement, not a bug
Projects
MueLu
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucbv