Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moertel: Comparing signed and unsigned variables breaks auto-tester #6698

Closed
lucbv opened this issue Jan 30, 2020 · 2 comments
Closed

Moertel: Comparing signed and unsigned variables breaks auto-tester #6698

lucbv opened this issue Jan 30, 2020 · 2 comments
Assignees
@lucbv
Labels
pkg: Moertel type: bug The primary issue is a bug in Trilinos code or tests

Comments

@lucbv
Copy link
Contributor

lucbv commented Jan 30, 2020

Bug Report

@kliegeois

Description

Simply need to change some std::size_t into int
Kim, if you could run with -Werror on when you make changes that would be nice ; )
@lucbv lucbv added type: bug The primary issue is a bug in Trilinos code or tests pkg: Moertel labels Jan 30, 2020
@lucbv lucbv self-assigned this Jan 30, 2020
lucbv added a commit to lucbv/Trilinos that referenced this issue Jan 30, 2020
@lucbv
Moertel: fix warnings due to signed/unsigned comparison, see issue tr…
0bd69a9 
…ilinos#6698
@lucbv lucbv mentioned this issue Jan 30, 2020
Merged
trilinos-autotester added a commit that referenced this issue Jan 31, 2020
@trilinos-autotester
Merge Pull Request #6699 from lucbv/Trilinos/Moertel_fix_warning
45dca80 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Moertel: fix warnings due to signed/unsigned comparison, see issue #6698
PR Author: lucbv
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jan 31, 2020
Merge 'trilinos/Trilinos:develop' (45dca80) into 'tcad-charon/Trilino…
75a42c2 
…s:develop' (2bfd2c7).

* trilinos-develop: (111 commits)
  Moertel: fix warnings due to signed/unsigned comparison, see issue trilinos#6698
  Add clang-7.0.1 explicitly in parsing (ATDV-291)
  MueLu ParameterListInterpreter test: Remove and regenerate xml
  PyTrilinos: Update swig interface files for SWIG 4.0
  PyTrilinos: Update build system for SWIG 4.0
  PyTrilinos: Replace SWIGEMPTYHACK with PYTRILINOS_NULLSTR
  MueLu: adding thresholding of the interpolation values in GeometricInterpolationPFactory, see issue trilinos#6681
  Made default clang7, tested with openmp and empire
  This turns off the Anasazi_Epetra_OrthoManagerGenTester_0_MPI_4 test
  Zoltan2: expose RCM root node options
  Zoltan2: use stable sort in RCM and AMD
  Belos: removed deprecated Belos::toString()
  Tacho - remove the word
  atdm ats2: Create /tmp/<userid>/ if it does not exist (CDOFA-72)
  ATDM 'ats2' fix names of builds to match SPARC builds (COFA-72)
  Fixups for atdm/ats2/environment.sh (CDOFA-72)
  Make default 'gnu' and 'cuda' builds (CDOFA-72)
  Add whitespace to improve readability (CDOFA-72)
  Add comment that we can't purge modules and why (CDOFA-72)
  ATDM: Implemented PR feedback
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Feb 1, 2020
Merge 'trilinos/Trilinos:develop' (4cfa684) into 'tcad-charon/Trilino…
ed8eae8 
…s:develop' (2bfd2c7).

* trilinos-develop: (122 commits)
  Tpetra: fixing small typo
  Moertel: fix warnings due to signed/unsigned comparison, see issue trilinos#6698
  Incoprporating changes suggested in PR
  Tpetra: adding benchmark for CrsMatrix::apply, see issue trilinos#6692
  Add clang-7.0.1 explicitly in parsing (ATDV-291)
  Tpetra::CrsGraph: Fix build errors relating to unique_ptr
  MueLu ParameterListInterpreter test: Remove and regenerate xml
  Tpetra::CrsGraph::makeIndicesLocal: Add verbose output
  Tpetra::CrsMatrix::globalAssemble: Add verbose debugging output
  Tpetra::CrsMatrix::fillLocalMatrix: Add verbose output
  Tpetra::CrsMatrix::fillLocalGraphAndMatrix: Add verbose output
  Tpetra::CrsMatrix: Add more verbose output on allocation
  Tpetra: Add verbose debugging output to padCrsArrays
  PyTrilinos: Update swig interface files for SWIG 4.0
  PyTrilinos: Update build system for SWIG 4.0
  PyTrilinos: Replace SWIGEMPTYHACK with PYTRILINOS_NULLSTR
  Tpetra::Crs{Graph,Matrix}: Add verbose output for memory use
  MueLu: adding thresholding of the interpolation values in GeometricInterpolationPFactory, see issue trilinos#6681
  Made default clang7, tested with openmp and empire
  This turns off the Anasazi_Epetra_OrthoManagerGenTester_0_MPI_4 test
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Feb 2, 2020
Merge 'trilinos/Trilinos:develop' (c486903) into 'tcad-charon/Trilino…
a24b50d 
…s:develop' (2bfd2c7).

* trilinos-develop: (129 commits)
  Intrepid2: Temporarily disabling tests failing on some machines (Issue trilinos#6246)
  ATDM: cee-rhel6: Change from openmpi-4.0.1 to openmpi-4.0.2 (ATDV-289)
  Add test for periodic parallel fpp decomposition
  IOSS: cgns - fix handling of periodic single-block models in parallel
  Tpetra: fixing small typo
  Moertel: fix warnings due to signed/unsigned comparison, see issue trilinos#6698
  Incoprporating changes suggested in PR
  Tpetra: adding benchmark for CrsMatrix::apply, see issue trilinos#6692
  Add clang-7.0.1 explicitly in parsing (ATDV-291)
  Tpetra::CrsGraph: Fix build errors relating to unique_ptr
  MueLu ParameterListInterpreter test: Remove and regenerate xml
  Tpetra::CrsGraph::makeIndicesLocal: Add verbose output
  Tpetra::CrsMatrix::globalAssemble: Add verbose debugging output
  Tpetra::CrsMatrix::fillLocalMatrix: Add verbose output
  Tpetra::CrsMatrix::fillLocalGraphAndMatrix: Add verbose output
  Tpetra::CrsMatrix: Add more verbose output on allocation
  Tpetra: Add verbose debugging output to padCrsArrays
  PyTrilinos: Update swig interface files for SWIG 4.0
  PyTrilinos: Update build system for SWIG 4.0
  PyTrilinos: Replace SWIGEMPTYHACK with PYTRILINOS_NULLSTR
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Feb 2, 2020
Merge 'trilinos/Trilinos:develop' (200c15e) into 'tcad-charon/Trilino…
0dcc2ae 
…s:develop' (2bfd2c7).

* trilinos-develop: (130 commits)
  Intrepid2: Temporarily disabling tests failing on some machines (Issue trilinos#6246)
  Tempus: Add Improved Doc for DIRK
  ATDM: cee-rhel6: Change from openmpi-4.0.1 to openmpi-4.0.2 (ATDV-289)
  Add test for periodic parallel fpp decomposition
  IOSS: cgns - fix handling of periodic single-block models in parallel
  Tpetra: fixing small typo
  Moertel: fix warnings due to signed/unsigned comparison, see issue trilinos#6698
  Incoprporating changes suggested in PR
  Tpetra: adding benchmark for CrsMatrix::apply, see issue trilinos#6692
  Add clang-7.0.1 explicitly in parsing (ATDV-291)
  Tpetra::CrsGraph: Fix build errors relating to unique_ptr
  MueLu ParameterListInterpreter test: Remove and regenerate xml
  Tpetra::CrsGraph::makeIndicesLocal: Add verbose output
  Tpetra::CrsMatrix::globalAssemble: Add verbose debugging output
  Tpetra::CrsMatrix::fillLocalMatrix: Add verbose output
  Tpetra::CrsMatrix::fillLocalGraphAndMatrix: Add verbose output
  Tpetra::CrsMatrix: Add more verbose output on allocation
  Tpetra: Add verbose debugging output to padCrsArrays
  PyTrilinos: Update swig interface files for SWIG 4.0
  PyTrilinos: Update build system for SWIG 4.0
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Feb 3, 2020
Merge 'trilinos/Trilinos:develop' (200c15e) into 'tcad-charon/Trilino…
4a9ef31 
…s:develop' (2bfd2c7).

* trilinos-develop: (130 commits)
  Intrepid2: Temporarily disabling tests failing on some machines (Issue trilinos#6246)
  Tempus: Add Improved Doc for DIRK
  ATDM: cee-rhel6: Change from openmpi-4.0.1 to openmpi-4.0.2 (ATDV-289)
  Add test for periodic parallel fpp decomposition
  IOSS: cgns - fix handling of periodic single-block models in parallel
  Tpetra: fixing small typo
  Moertel: fix warnings due to signed/unsigned comparison, see issue trilinos#6698
  Incoprporating changes suggested in PR
  Tpetra: adding benchmark for CrsMatrix::apply, see issue trilinos#6692
  Add clang-7.0.1 explicitly in parsing (ATDV-291)
  Tpetra::CrsGraph: Fix build errors relating to unique_ptr
  MueLu ParameterListInterpreter test: Remove and regenerate xml
  Tpetra::CrsGraph::makeIndicesLocal: Add verbose output
  Tpetra::CrsMatrix::globalAssemble: Add verbose debugging output
  Tpetra::CrsMatrix::fillLocalMatrix: Add verbose output
  Tpetra::CrsMatrix::fillLocalGraphAndMatrix: Add verbose output
  Tpetra::CrsMatrix: Add more verbose output on allocation
  Tpetra: Add verbose debugging output to padCrsArrays
  PyTrilinos: Update swig interface files for SWIG 4.0
  PyTrilinos: Update build system for SWIG 4.0
  ...
@lucbv
Copy link
Contributor Author

lucbv commented Feb 3, 2020

This seem to be resolved now so I'm closing the issue

@lucbv lucbv closed this as completed Feb 3, 2020
@kliegeois
Copy link
Contributor

Sorry for those signed-unsigned comparisons @lucbv !
And sorry for not seeing that issue earlier.

@trilinos-autotester trilinos-autotester mentioned this issue Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucbv lucbv

Labels
pkg: Moertel type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kliegeois @lucbv