Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store account separately #288

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Store account separately #288

merged 3 commits into from
Jul 25, 2023

Conversation

ryutamago
Copy link
Contributor

@ryutamago ryutamago commented Jul 23, 2023

Store account separately

Task link

Types of changes

store accounts under a new local storage key "account"

first commit: reorganize the file structures
second commit: separated the stores.ts
third commit: introduce a new key "accouns" and moved the slice there

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • Documentation Update

Steps to reproduce

  • go to applications -> local storage and confirm the accounts are stored separately from the persist:root

This was referenced Jul 23, 2023
@ryutamago ryutamago force-pushed the store-account-separately branch 2 times, most recently from 88301b7 to 89bae4c Compare July 25, 2023 04:32
@ryutamago ryutamago marked this pull request as ready for review July 25, 2023 07:39
* rename from "store" to "redux"
* Move the slices and tests to "redux/slices"
* rename from "reducer test" to "slice test"
* separate the combined reducers from store.ts
* export default store
@ryutamago ryutamago merged commit ce66af3 into main Jul 25, 2023
1 check passed
@ryutamago ryutamago deleted the store-account-separately branch July 25, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants