Make accountslice take an array #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,10 +38,8 @@ const accountsSlice = createSlice({ | |||
| state.items = newAccounts; | |||
| delete state.seedPhrases[fingerPrint]; | |||
| }, | |||
| add: (state, { payload }: { type: string; payload: ImplicitAccount | ImplicitAccount[] }) => { | |||
| const accounts = Array.isArray(payload) ? payload : [payload]; | |||
There was a problem hiding this comment.
not sure if passing in just one object was a problem but I'd write it as state.items = concatUnique(state.items, [payload].flat()); WDYT?
There was a problem hiding this comment.
i noticed there was no other places in the codebase that passes in a single item other than the tests so i think it's better to keep the API simple like this
serjonya-trili
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Accounts slice take an array
This is a refactoring PR part of #288
We make the accountSlice.add action more generic by taking an array of accounts
Types of changes
Put an
xin the boxes that apply