-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
output
doesn't work with single space strings
#81
Comments
output
doesn't work with empty stringsoutput
doesn't work with single space strings
This should be all taken care of according to tests and stuff. Please let me know if you see differently |
@trilom this may work in tests but I've confirmed it does not work in a real workflow. It looks like GitHub automatically trims all input strings when you call |
We'd likely need some kind of sentinel value for this case e.g. the word "space" to represent an empty space. |
…ace. the assumption here is that 'json' is default, if you use ' ' it will be '' which is the app default, not the action default of 'json' I don't specifically like the solution in #81 of having a string that represents something. Not that many people will need the string 'space' over the string ' ' but this is just logical preference for WYSIWYG.
`- name: File Changes Action uses: trilom/file-changes-action@v1.2.2` ## [1.2.2](v1.2.1...v1.2.2) (2020-03-25) ### Bug Fixes * **issue_comment:** this needs to return PR info not commit info if before and after explicitly set, else PR ([eee976b](eee976b)) * **naming:** renamed "deleted" to "removed". sorry if this is breaking for you. ([800537f](800537f)) * **pull_request_synchronize events:** issue with PR Synchronize events, it would return commit files instead of PR files, this is adjusted to return ALL PR files with PR synchronize event ([fb7bcc7](fb7bcc7)) * **space issue:** this should resolve the issue with using a blank space. the assumption here is that 'json' is default, if you use ' ' it will be '' which is the app default, not the action default of 'json' ([0e4184f](0e4184f)), closes [#81](#81)
I arrived here from pre-commit/action#7 (comment) However, I see that the So, I assume |
Describe the bug
When using the
output
parameter with an empty string, the files are concatenated together without any separator.Workflow
Expected behavior
Files should output with spaces between them, e.g.
file1 file2
. Instead, they are output together:file1file2
The text was updated successfully, but these errors were encountered: