Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#81: Allow single spaces in format #88

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Conversation

dorner
Copy link
Contributor

@dorner dorner commented Mar 23, 2020

Type of Change

  • New feature
  • Bug fix
  • Documentation
  • Refactor
  • Chore

Resolves

Describe Changes

Adds a "space" special delimiter value so this works with single spaces (GitHub automatically trims these values before the code gets to them).

@trilom trilom changed the base branch from master to fix-payloads March 23, 2020 17:24
@trilom
Copy link
Owner

trilom commented Mar 23, 2020

Thank you - i'm going to merge this into the fix-payloads branch where I am circling around testing regarding this specific issue. I was still trying to understand where it was being trimmed at - so you're saying if you pass a ' '(single space) to the action as an output or fileOutput input then the app receives a '' (trimmed space)?

@trilom trilom merged commit dd52d14 into trilom:fix-payloads Mar 23, 2020
@dorner
Copy link
Contributor Author

dorner commented Mar 23, 2020

Correct - at least from my own experiments. The YAML file has a single space ' ' but getInput returns an empty string.

@trilom
Copy link
Owner

trilom commented Mar 23, 2020

Thank you so much for the feedback, and the blog shoutout. I really appreciate it. I'll have this fixed and merged soon.

@dorner
Copy link
Contributor Author

dorner commented Mar 23, 2020

Awesome, thanks!

@dorner dorner deleted the fix-spaces branch June 5, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output doesn't work with single space strings
2 participants