Use exponential backoff retry strategy for glue client #23039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-with-secrets sha=61c3c5e23162890cb76fb3b2340fdfdd2c2a8b27 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/10388756346 |
|
@ebyhr is there anything I can do to retry job, or you need to schedule retry? I see there seems to be 1 clickhouse flaky test |
|
@oskar-szwajkowski We can ignore the failure because we're sure that ClickHouse connector is unrelated to this change. @electrum Could you review this PR? |
electrum
approved these changes
Aug 26, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueMetastoreModule.java
Outdated
Show resolved
Hide resolved
oskar-szwajkowski
force-pushed
the
osz/glue-client-better-backoff-strategy
branch
2 times, most recently
from
c1ca644
to
8dd12b4
Compare
Default strategy was not good enough for handling concurrent modifications, which led to flaky behavior in concurrent modifications tests like TestIcebergGlueCatalogConnectorSmokeTest#testDeleteRowsConcurrently
oskar-szwajkowski
force-pushed
the
osz/glue-client-better-backoff-strategy
branch
from
8dd12b4
to
f4b839f
Compare
|
Let me merge to fix flaky tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merging #22814, @ebyhr reporter that
TestIcebergGlueCatalogConnectorSmokeTest#testDeleteRowsConcurrentlybecame flakyAfter running it several times locally, I found that commit 4b28d9b seems to be problematic
Default retry strategy, which brings default backoff strategy, wasn't good enough when dealing with such concurrent use cases. After changing to exponential backoff strategy it feels much more stable now.
Additional context and related issues
#22814
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: