Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sounds not playing or distorted #7905

Closed
FrostionAAA opened this issue Oct 14, 2020 · 10 comments · Fixed by #7940
Closed

Sounds not playing or distorted #7905

FrostionAAA opened this issue Oct 14, 2020 · 10 comments · Fixed by #7940
Labels
Problem A problem, bug, defect - something to fix

Comments

@FrostionAAA
Copy link
Contributor

Map sounds and their playback in the newest prereleases of tripleA seems to be bugged. (at least in v2.3.22024)
Sounds are either not played or they are played very distorted.
I think it can be recreated by just starting an all AI game of Dragon War (distorted) or Age of Tribes (no sound beyond intro sound)

@FrostionAAA FrostionAAA added the Problem A problem, bug, defect - something to fix label Oct 14, 2020
@tvleavitt
Copy link

I noticed this the other day when starting a game... it settled down after a few minutes, but it was really really jittery on launch.

@beelee1
Copy link
Contributor

beelee1 commented Oct 15, 2020

I'm not sure if this is related #7865 but it had some sound issues as well.

@trevan
Copy link
Contributor

trevan commented Oct 15, 2020

Can one of you try and find which build started showing this issue?

@FrostionAAA
Copy link
Contributor Author

@trevan I will when I have the time. Thanks.

@beelee1
Copy link
Contributor

beelee1 commented Oct 16, 2020

It doesn't do it in 2.2.20868 I'll check a few other others after a bit unless Frostion finds it first :)

ahh I may have misunderstood where I was. Please ignore if need be.

@trevan trevan mentioned this issue Oct 18, 2020
@DanVanAtta
Copy link
Member

I think this is likely to be fixed at same time as: #7865

It seems the 'resource loader' gets messed up, at which point resources like sounds are not found. It's the same problem for not being able to find images, the resource loader is the thing that gives the 'root file path' from where we find things like sounds and images.

@FrostionAAA
Copy link
Contributor Author

FrostionAAA commented Oct 19, 2020

I am not sure, but i think 2.3.21422 is the first version that distorts sounds.
And maybe 2.3.21385 is the last version that does not have distortions.
I think this lists the changes: 2.3.21385...2.3.21422
I hope the sound issue can be figured out :-)

@trevan
Copy link
Contributor

trevan commented Oct 19, 2020

The only PR in that range that would affect sound is #7602. The message is "Fix: Disable audio if there is no audio device" so it would seem like that is a good possibility.

@trevan
Copy link
Contributor

trevan commented Oct 19, 2020

Yup, that change caused this. I played Dragon Age with Hard AI on master with the change reverted and the sound worked fine.

@trevan
Copy link
Contributor

trevan commented Oct 19, 2020

@FrostionAAA thanks for finding the initial problematic build. I've created a PR with a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Problem A problem, bug, defect - something to fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants