Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new audio device for each clip. #7940

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

trevan
Copy link
Contributor

@trevan trevan commented Oct 19, 2020

Multiple clips can play together and they each need their own audio
device. Otherwise, the sound comes out garbled.

Fixes #7905 and #7865

Testing

Play Dragon War with Hard AI for all players. The sounds should play correctly. Each battle generally plays about 3 clips at the same time.

Screens Shots

Additional Notes to Reviewer

Release Note

Multiple clips can play together and they each need their own audio
device. Otherwise, the sound comes out garbled.
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #7940 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7940   +/-   ##
=========================================
  Coverage     24.83%   24.84%           
  Complexity     7281     7281           
=========================================
  Files          1251     1251           
  Lines         79065    79067    +2     
  Branches      11154    11154           
=========================================
+ Hits          19639    19643    +4     
+ Misses        57335    57330    -5     
- Partials       2091     2094    +3     
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/org/triplea/sound/ClipPlayer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/games/strategy/triplea/delegate/Matches.java 44.84% <0.00%> (-0.11%) 372.00% <0.00%> (-1.00%)
.../strategy/triplea/odds/calculator/DummyPlayer.java 56.04% <0.00%> (+5.49%) 17.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afeb445...4626b11. Read the comment docs.

@DanVanAtta
Copy link
Member

@trevan I added a commit to this branch to remove a needless reference to 'audioDevice' (changed to a boolean) and secondarily avoided shadowing the 'audioDevice' variable.

@DanVanAtta DanVanAtta merged commit 0336867 into triplea-game:master Oct 20, 2020
@trevan trevan deleted the audio-issues branch October 31, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sounds not playing or distorted
2 participants