Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClipPlayer cleanup #8588

Merged
merged 3 commits into from
Jan 9, 2021
Merged

ClipPlayer cleanup #8588

merged 3 commits into from
Jan 9, 2021

Conversation

RoiEXLab
Copy link
Member

@RoiEXLab RoiEXLab commented Jan 5, 2021

I stumbled across this class and noticed a lot of code is actually redundant or unecessarily complicated, so I decided to simplify it a bit.

I tested my changes with a custom map and custom sound files and it worked fine.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #8588 (43de4f1) into master (5d6c93a) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8588      +/-   ##
============================================
+ Coverage     24.90%   24.91%   +0.01%     
+ Complexity     7371     7370       -1     
============================================
  Files          1288     1288              
  Lines         80308    80253      -55     
  Branches      11013    11000      -13     
============================================
- Hits          19999    19998       -1     
+ Misses        58240    58185      -55     
- Partials       2069     2070       +1     
Impacted Files Coverage Δ Complexity Δ
...in/java/games/strategy/triplea/ResourceLoader.java 21.78% <0.00%> (+0.82%) 11.00 <0.00> (ø)
...main/java/games/strategy/triplea/ui/UiContext.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...re/src/main/java/org/triplea/sound/ClipPlayer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/org/triplea/sound/SoundOptionCheckBox.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../src/main/java/org/triplea/sound/SoundOptions.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lea/ai/flowfield/influence/InfluenceTerritory.java 96.96% <0.00%> (-3.04%) 13.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6c93a...43de4f1. Read the comment docs.

@DanVanAtta
Copy link
Member

@RoiEXLab could you check this issue: #7905 for additional test cases. There were some subtle bug fixes in ClipPlayer recently.

@RoiEXLab
Copy link
Member Author

RoiEXLab commented Jan 7, 2021

@DanVanAtta Sound is playing fine for Dragon War

@DanVanAtta DanVanAtta merged commit f3face9 into triplea-game:master Jan 9, 2021
@RoiEXLab RoiEXLab deleted the clip-player-cleanup branch January 10, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants