[BUILD] Fix linker error in Membar.cpp #3421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhat-nguyen
changed the title
Jokeren
approved these changes
Mar 19, 2024
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
We found an issue when linking `TritonAnalysis` without first fully
building triton.
```
In file included from ~/triton/lib/Analysis/Membar.cpp:6:
In file included from ~/triton/include/triton/Conversion/TritonGPUToLLVM/Utility.h:8:
~/triton/include/triton/Dialect/NVGPU/IR/Dialect.h:32:10: fatal error: 'triton/Dialect/NVGPU/IR/Dialect.h.inc' file not found
#include "triton/Dialect/NVGPU/IR/Dialect.h.inc"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
ninja: build stopped: subcommand failed.
```
So `Membar.cpp` includes `Utility.h` from `TritonGPUToLLVM` which in
turns needs `NVGPU` and its tablegen files. `TritonAnalysis`'s cmake
doesn't list neither `TritonGPUToLLVM` nor `NVGPU` as dependencies,
hence the linker error. Technically we should have `TritonAnalysis`
depend on `TritonGPUToLLVM`, but `TritonGPUToLLVM` already depends on
`TritonAnalysis`.
Fortunately, `Membar.cpp` doesn't use this `Utility.h` file, so we could
simply delete this include to break both the linker error and the
potential circular dependency. Also note that the error doesn't show up
in the full build because the tablegen files from `NVGPU` are already
generated by the time we link the all libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue when linking
TritonAnalysiswithout first fully building triton.So
Membar.cppincludesUtility.hfromTritonGPUToLLVMwhich in turns needsNVGPUand its tablegen files.TritonAnalysis's cmake doesn't list neitherTritonGPUToLLVMnorNVGPUas dependencies, hence the linker error. Technically we should haveTritonAnalysisdepend onTritonGPUToLLVM, butTritonGPUToLLVMalready depends onTritonAnalysis.Fortunately,
Membar.cppdoesn't use thisUtility.hfile, so we could simply delete this include to break both the linker error and the potential circular dependency. Also note that the error doesn't show up in the full build because the tablegen files fromNVGPUare already generated by the time we link the all libs.