Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCID Camera Client #159

Merged
merged 75 commits into from
May 8, 2024
Merged

LUCID Camera Client #159

merged 75 commits into from
May 8, 2024

Conversation

atar13
Copy link
Member

@atar13 atar13 commented Apr 23, 2024

Closes #29

shree-venkatesh and others added 30 commits October 29, 2023 22:37
camera playground can now run and use arena api only if you specify a few libraries that are dynamically loaded from LD_LIBRARY_PATH. this isn't the most optimal solution and we should seek an alternate approach
camera playground can now run and use arena api only if you specify a few libraries that are dynamically loaded from LD_LIBRARY_PATH. this isn't the most optimal solution and we should seek an alternate approach
@atar13 atar13 marked this pull request as ready for review May 7, 2024 06:57
@atar13
Copy link
Member Author

atar13 commented May 7, 2024

This PR is ready for review. It ended up touching a lot of files across the project so those reviewing can focus on files in include/camera and src/camera.

I can't figure out why the unit tests are failing. It seems to not be able to find the LucidCamera declaration. It's defined in include/camera/lucid.hpp but is behind a #ifdef that is set in the deps/arena.cmake file if Arena SDK is installed. I'll do some more digging but you can run ninja test and ninja obcpp to verify that everything is compiling correctly.

Copy link
Contributor

@Tyler-Lentz Tyler-Lentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style wise everything looks good, thanks for putting this together.

I think the tests are failing however? Looks like a compile error with creating a lucid camera so maybe a test is out of date. So once we fix that and verify still works on the jetson I think we should be good

@atar13
Copy link
Member Author

atar13 commented May 7, 2024

I think the tests are failing however? Looks like a compile error with creating a lucid camera so maybe a test is out of date. So once we fix that and verify still works on the jetson I think we should be good

Yeah that's what this comment was about. I'll try to figure it out:

#159 (comment)

@Tyler-Lentz
Copy link
Contributor

I think the tests are failing however? Looks like a compile error with creating a lucid camera so maybe a test is out of date. So once we fix that and verify still works on the jetson I think we should be good

Yeah that's what this comment was about. I'll try to figure it out:

#159 (comment)

oh sorry i didn't see that

Copy link
Contributor

@Samir-Rashid Samir-Rashid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works. I'm a bit hesitant to merge because there are a lot of must fix problems left. To make sure this doesn't get even more out of hand, we should merge now. I do not want to block work on main that builds on this.

@atar13
Copy link
Member Author

atar13 commented May 8, 2024

Tests are passing now after some shenanigans with GitHub actions not detecting the environment variable for the ArenaSDK location set in the Docker image.

@atar13 atar13 requested a review from Tyler-Lentz May 8, 2024 06:44
Copy link
Contributor

@Tyler-Lentz Tyler-Lentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work soldier o7

@atar13 atar13 merged commit b7dec42 into main May 8, 2024
2 checks passed
@Tyler-Lentz Tyler-Lentz deleted the feat/lucid-camera branch June 12, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black Bars/Dropped Packets with LUCID Camera Create LUCID camera interface implementation
6 participants