-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUCID Camera Client #159
LUCID Camera Client #159
Conversation
camera playground can now run and use arena api only if you specify a few libraries that are dynamically loaded from LD_LIBRARY_PATH. this isn't the most optimal solution and we should seek an alternate approach
camera playground can now run and use arena api only if you specify a few libraries that are dynamically loaded from LD_LIBRARY_PATH. this isn't the most optimal solution and we should seek an alternate approach
…ixes in interface.hpp
(spooky)
…o feat/lucid-camera
This PR is ready for review. It ended up touching a lot of files across the project so those reviewing can focus on files in I can't figure out why the unit tests are failing. It seems to not be able to find the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style wise everything looks good, thanks for putting this together.
I think the tests are failing however? Looks like a compile error with creating a lucid camera so maybe a test is out of date. So once we fix that and verify still works on the jetson I think we should be good
Yeah that's what this comment was about. I'll try to figure it out: |
oh sorry i didn't see that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works. I'm a bit hesitant to merge because there are a lot of must fix problems left. To make sure this doesn't get even more out of hand, we should merge now. I do not want to block work on main that builds on this.
Tests are passing now after some shenanigans with GitHub actions not detecting the environment variable for the ArenaSDK location set in the Docker image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work soldier o7
Closes #29