Merge pull request #1491 from troessner/update-dependencies

Update dependencies
troessner · Oct 5, 2019 · 6099715 · 6099715
2 parents f895056 + 8dc78e9
commit 6099715
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/Gemfile b/Gemfile
@@ -7,15 +7,15 @@ ruby RUBY_VERSION
 group :development do
   gem 'aruba',               '~> 0.14.8'
   gem 'cucumber',            '~> 3.0'
-  gem 'factory_bot',         '~> 5.0'
+  gem 'factory_bot',         '~> 5.0', '!= 5.1.0'
   gem 'kramdown',            '~> 2.1'
   gem 'kramdown-parser-gfm', '~> 1.0'
-  gem 'rake',                '~> 12.0'
+  gem 'rake',                '~> 13.0'
   gem 'rspec',               '~> 3.0'
   gem 'rspec-benchmark',     '~> 0.5.0'
-  gem 'rubocop',             '~> 0.74.0'
-  gem 'rubocop-performance', '~> 1.4.0'
-  gem 'rubocop-rspec',       '~> 1.35.0'
+  gem 'rubocop',             '~> 0.75.0'
+  gem 'rubocop-performance', '~> 1.5.0'
+  gem 'rubocop-rspec',       '~> 1.36.0'
   gem 'simplecov',           '~> 0.17.0'
   gem 'yard',                '~> 0.9.5'
 

diff --git a/lib/reek/smell_detectors/too_many_constants.rb b/lib/reek/smell_detectors/too_many_constants.rb
@@ -35,7 +35,7 @@ def self.default_config
       # @return [Array<SmellWarning>]
       #
       def sniff
-        count = context.local_nodes(:casgn).reject(&:defines_module?).length
+        count = context.local_nodes(:casgn).count { |it| !it.defines_module? }
 
         return [] if count <= max_allowed_constants
 

diff --git a/spec/reek/cli/application_spec.rb b/spec/reek/cli/application_spec.rb
@@ -9,7 +9,7 @@
           described_class.new ['--foo']
         end
       end
-      expect(call).to raise_error(SystemExit) do |error|
+      expect(&call).to raise_error(SystemExit) do |error|
         expect(error.status).to eq Reek::CLI::Status::DEFAULT_ERROR_EXIT_CODE
       end
     end

diff --git a/spec/reek/examiner_spec.rb b/spec/reek/examiner_spec.rb
@@ -6,6 +6,7 @@
   it 'is not smelly' do
     expect(examiner).not_to be_smelly
   end
+
   it 'finds no smells' do
     expect(examiner.smells.length).to eq(0)
   end

diff --git a/spec/reek/smell_configuration_spec.rb b/spec/reek/smell_configuration_spec.rb
@@ -18,10 +18,12 @@
     it { expect(smell_config.merge('enabled' => true)).to eq(base_config) }
     it { expect(smell_config.merge('exclude' => [])).to eq(base_config) }
     it { expect(smell_config.merge('accept' => ['_'])).to eq(base_config) }
+
     it do
       updated = smell_config.merge('reject' => [/^.$/, /[0-9]$/, /[A-Z]/])
       expect(updated).to eq(base_config)
     end
+
     it do
       updated = smell_config.merge('accept' => ['_'], 'enabled' => true)
       expect(updated).to eq(base_config)