Update dependencies #1491
Merged
Update dependencies #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mvz
commented
Sep 27, 2019
•
mvz
commented
- Auto-update rake to 13.0.0
- Auto-update rubocop to 0.75.0
- Auto-update rubocop-performance to 1.5.0
- Auto-update rubocop-rspec to 1.36.0
- Autocorrect new RSpec/EmptyLineAfterExample offenses
- Fix new Performance/Count offense
- Disallow version 5.1.0 of factory_bot dependency to support JRuby builds
|
The JRuby errors on |
|
Same. 🤷♂️ |
|
It's due to this problem: thoughtbot/factory_bot#1331 |
chastell
previously requested changes
Oct 1, 2019
|
Well, I agree one would hope so, but no fix has even been committed to master. |
|
I'll rebase this mess 🙂 |
mvz
force-pushed
the
update-dependencies
branch
from
dde2a66 to
0608969
Compare
|
Ha, it looks like an RSpec update surfaced a new spec issue 🤷♂️. |
|
Hm, it's due to this: rspec/rspec-expectations#1125 I'm unsure why such a breaking change was merged for a |
* Auto-update rake to 13.0.0 * Auto-update rubocop to 0.75.0 * Auto-update rubocop-performance to 1.5.0 * Auto-update rubocop-rspec to 1.36.0 * Autocorrect new RSpec/EmptyLineAfterExample offenses * Fix new Performance/Count offense * Disallow version 5.1.0 of factory_bot dependency to support JRuby builds * Change use of raise_error matcher to support rspec-expectations 3.8.5. Co-Authored-By: Piotr Szotkowski <chastell@chastell.net>
mvz
force-pushed
the
update-dependencies
branch
from
0608969 to
8dc78e9
Compare
|
OMG. OK, let’s merge this in before other deps follow suit. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.