Added Cisco Meraki API Key detector #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
reviewed
Oct 4, 2024
rgmz
reviewed
Oct 4, 2024
pkg/detectors/meraki/meraki.go
Outdated
| dataStr := string(data) | ||
|
|
||
| // uniqueMatches will hold unique match values and ensure we only process unique matches found in the data string | ||
| var uniqueMatches = make(map[string]bool) |
There was a problem hiding this comment.
Not really a big deal, but for sets the convention is to use map[string]struct{} instead of map[string]bool. This is both because the value of bool isn't used and empty structs save allocations.
e.g., https://www.reddit.com/r/golang/comments/15vaxlu/the_set_data_structure_in_go/
Suggested change
| var uniqueMatches = make(map[string]bool) | |
| var uniqueMatches = make(map[string]struct{}) |
zricethezav
approved these changes
Oct 7, 2024
abmussani
added a commit
to abmussani/trufflehog
that referenced
this pull request
Oct 9, 2024
* main: (79 commits) Log skipped files on debug level (trufflesecurity#3383) build: update retracted bluemonday ver (trufflesecurity#3369) Fix git binary handling and add a smoke test (trufflesecurity#3379) fix(deps): update module google.golang.org/protobuf to v1.35.1 (trufflesecurity#3382) Added Cisco Meraki API Key detector (trufflesecurity#3367) improved the agora detector (trufflesecurity#3360) fix(deps): update module github.com/xanzy/go-gitlab to v0.110.0 (trufflesecurity#3376) fix(deps): update golang.org/x/exp digest to 225e2ab (trufflesecurity#3371) fix(deps): update module golang.org/x/net to v0.30.0 (trufflesecurity#3373) fix(deps): update module golang.org/x/crypto to v0.28.0 (trufflesecurity#3372) chore(deps): update sigstore/cosign-installer action to v3.7.0 (trufflesecurity#3368) fix(deps): update module cloud.google.com/go/storage to v1.44.0 (trufflesecurity#3366) fix(deps): update module github.com/schollz/progressbar/v3 to v3.16.1 (trufflesecurity#3365) [refactor] - Decouple Metrics From Cache Implementation (trufflesecurity#3355) fix(deps): update module github.com/snowflakedb/gosnowflake to v1.11.2 (trufflesecurity#3363) Updated Cosign Install URL (trufflesecurity#3364) fix(deps): update module github.com/jedib0t/go-pretty/v6 to v6.6.0 (trufflesecurity#3361) Added Pattern test cases for detectors (trufflesecurity#3354) remove size check (trufflesecurity#3351) fix(deps): update module go.mongodb.org/mongo-driver to v1.17.1 (trufflesecurity#3357) ... # Conflicts: # go.sum
abmussani
added a commit
to abmussani/trufflehog
that referenced
this pull request
Oct 14, 2024
* main: (127 commits) Update SaladCloud description (trufflesecurity#3399) fix tests (trufflesecurity#3400) [chore] Update custom detector default description (trufflesecurity#3398) add description to salad (trufflesecurity#3397) Add detector for SaladCloud API Keys (trufflesecurity#3273) fix(deps): update module github.com/xanzy/go-gitlab to v0.111.0 (trufflesecurity#3393) Add SliceContainsString common util (trufflesecurity#3395) fix: pr template link to golangci-lint (trufflesecurity#3392) fix(deps): update golang.org/x/exp digest to f66d83c (trufflesecurity#3389) Separate detector tests into unit/integration (trufflesecurity#3274) Manually upgrade github dep (trufflesecurity#3387) Updated Fastly Personal Token Detector (trufflesecurity#3386) fix(deps): update module google.golang.org/api to v0.200.0 (trufflesecurity#3391) [Fix] Snowflake privatelink Support (trufflesecurity#3286) Enhanced the easyinsight detector (trufflesecurity#3384) Log skipped files on debug level (trufflesecurity#3383) build: update retracted bluemonday ver (trufflesecurity#3369) Fix git binary handling and add a smoke test (trufflesecurity#3379) fix(deps): update module google.golang.org/protobuf to v1.35.1 (trufflesecurity#3382) Added Cisco Meraki API Key detector (trufflesecurity#3367) ... # Conflicts: # pkg/engine/defaults.go # pkg/pb/detectorspb/detectors.pb.go # proto/detectors.proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a new detector for Cisco Meraki API Keys.
Meraki: https://meraki.cisco.com/
API Documentation: https://developer.cisco.com/meraki/api-v1/introduction/
Test Cases:
Meraki API Key Detection:
Checklist:
make test-community)?make lintthis requires golangci-lint)?