Separate detector tests into unit/integration #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
force-pushed
the
test/separate
branch
2 times, most recently
from
5921f6a
to
9496ef7
Compare
|
@rgmz I think this is a worthwhile change. Is there a reason only a subset of the detectors are included in this PR? |
|
Those are the only ones that have unit tests AFAIK. |
|
I'm confused by the lint error: https://github.com/trufflesecurity/trufflehog/actions/runs/10848445504/job/30590845421?pr=3274 That variable appears to have never been used. I guess it didn't get flagged due to the build flag? Should be fixed now. |
rgmz
force-pushed
the
test/separate
branch
2 times, most recently
from
f602d05
to
d56d4ac
Compare
2 tasks
kashifkhan0771
approved these changes
Oct 10, 2024
|
Thanks @rgmz for this. |
2 tasks
|
Looks good to me, we should update the contributing docs too. That can be in a followup PR |
abmussani
added a commit
to abmussani/trufflehog
that referenced
this pull request
Oct 14, 2024
* main: (127 commits) Update SaladCloud description (trufflesecurity#3399) fix tests (trufflesecurity#3400) [chore] Update custom detector default description (trufflesecurity#3398) add description to salad (trufflesecurity#3397) Add detector for SaladCloud API Keys (trufflesecurity#3273) fix(deps): update module github.com/xanzy/go-gitlab to v0.111.0 (trufflesecurity#3393) Add SliceContainsString common util (trufflesecurity#3395) fix: pr template link to golangci-lint (trufflesecurity#3392) fix(deps): update golang.org/x/exp digest to f66d83c (trufflesecurity#3389) Separate detector tests into unit/integration (trufflesecurity#3274) Manually upgrade github dep (trufflesecurity#3387) Updated Fastly Personal Token Detector (trufflesecurity#3386) fix(deps): update module google.golang.org/api to v0.200.0 (trufflesecurity#3391) [Fix] Snowflake privatelink Support (trufflesecurity#3286) Enhanced the easyinsight detector (trufflesecurity#3384) Log skipped files on debug level (trufflesecurity#3383) build: update retracted bluemonday ver (trufflesecurity#3369) Fix git binary handling and add a smoke test (trufflesecurity#3379) fix(deps): update module google.golang.org/protobuf to v1.35.1 (trufflesecurity#3382) Added Cisco Meraki API Key detector (trufflesecurity#3367) ... # Conflicts: # pkg/engine/defaults.go # pkg/pb/detectorspb/detectors.pb.go # proto/detectors.proto
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Unlike integration tests, the detector's unit tests should always run. This helps catch bugs early; there is no upside and tremendous downside to keeping them together.
Checklist:
make test-community)?make lintthis requires golangci-lint)?