Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include integration test in generate.go #3415

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Include integration test in generate.go #3415

merged 1 commit into from
Oct 15, 2024

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Oct 15, 2024

Description:

Ensures that the separate unit and integration test files from #3274 get copied.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner October 15, 2024 18:24
@zricethezav
Copy link
Collaborator

Ah, very important catch @rgmz. 🙇🏻

ahrav
ahrav approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I totally forgot this got split up as well.

@ahrav ahrav merged commit c39c5cb into trufflesecurity:main Oct 15, 2024
13 checks passed
@rgmz rgmz deleted the chore/hack-script branch October 15, 2024 19:43
@blsaccess blsaccess mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgmz @zricethezav @ahrav