Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version displayed for msprime #22

Closed
jeromekelleher opened this issue Jan 27, 2021 · 6 comments · Fixed by #28
Closed

Wrong version displayed for msprime #22

jeromekelleher opened this issue Jan 27, 2021 · 6 comments · Fixed by #28

Comments

@jeromekelleher
Copy link
Member

The wrong version of msprime is being displayed on the intro page. For some reason, we've got version = "0.1.dev1", which means that either the custom sphinx extension defined in tskit-dev/msprime#1408 isn't being executed, or the sphinx config is somehow being overwritten later in the process.

The Python path must be OK, because we wouldn't get the autodocs output otherwise.

Any ideas @benjeffery?

@benjeffery
Copy link
Member

Odd, I can't recreate locally. I think we should use a more flexible way of getting the version number in anyway as I suggested over at tskit-dev/msprime#1396 (comment)

@jeromekelleher
Copy link
Member Author

Happy to look at alternatives to setting the version via sphinx.

@jeromekelleher
Copy link
Member Author

Maybe it's an issue with running in a venv? But, you always run everything in venvs, don't you? (So you should see it locally if so...)

@benjeffery
Copy link
Member

Yes, I'm always in a venv, I even wiped my venv and pip installed the CI-docs requirements, still couldn't recreate.

@jeromekelleher
Copy link
Member Author

Weird. A snippet of JS would be more flexible, allright, if we could do that.

@jeromekelleher
Copy link
Member Author

Looks like this is a problem with shallow clones done on Actions:

I'll try the fetch-depth: 0 fix and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants