Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git metadata for setuptools_scm #28

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Fix git metadata for setuptools_scm #28

merged 1 commit into from
Jan 29, 2021

Conversation

jeromekelleher
Copy link
Member

Closes #22

@jeromekelleher
Copy link
Member Author

Looks like this is working. The shallow git clone was mucking up setuptools_scm, which meant we couldn't determine the version number. The current make dist thing is a bit of a hack, but it works.

@benjeffery
Copy link
Member

Ahh, that explains it. Thanks for finding that one!

@benjeffery benjeffery merged commit ce766cf into tskit-dev:main Jan 29, 2021
@jeromekelleher jeromekelleher deleted the jeromekelleher-patch-1 branch January 29, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjeffery benjeffery Awaiting requested review from benjeffery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong version displayed for msprime
2 participants
@jeromekelleher @benjeffery