Upgrade Gradle to 7.3.3 & Android Gradle Plugin to 7.1.1 #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Gradle and Android Gradle Plugin to their latest versions. It also addresses issues that resulted from the upgrade with the goal of getting a successful
./gradlew build
command. It removes publishing related code - as it's no longer usable - in favour of adding publishing to our S3 Maven in a subsequent PR../gradlew wrapper --gradle-version 7.3.3 --distribution-type all
command.7.1.1
.android.useAndroidX=true
togradle.properties
. In PermissMe librarygradle.properties
was ignored, sogradle.properties-example
was introduced for this. However, sincegradle.properties
is already checked into the project, adding theandroid.useAndroidX
property is simpler. I think this is something we should address in the future to bring consistency across projects, however I don't think this PR is the right time & place to do it.buildToolsVersion
property which is no longer necessary and gets ignored by AGP.To test:
I unfortunately don't have any testing instructions for the project, but these are all build related changes and at least those can be verified by
./gradlew build
command which builds, tests and lints the projects. It'd be helpful to smoke test the example app if the reviewer is familiar with it.