Upgrade Gradle to 7.3.3 & Android Gradle Plugin to 7.1.1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obsantos
approved these changes
Feb 1, 2022
sample/build.gradle
Outdated
|
|
||
| defaultConfig { | ||
| applicationId "com.tumblr.permissme.sample" | ||
| minSdkVersion 16 | ||
| targetSdkVersion 28 | ||
| targetSdkVersion 30 |
There was a problem hiding this comment.
Should we target 31? We are working on upgrading this on the main repo, and the main blocker we have is the lack of Jdk 11 on Jenkins (which is also required for AGP 7.x), so we can do both at the same time
There was a problem hiding this comment.
same for compileSdkVersion
There was a problem hiding this comment.
oguzkocer
force-pushed
the
upgrade-gradle-and-agp
branch
from
8198b2c
to
3b617ac
Compare
Merged
oguzkocer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Gradle and Android Gradle Plugin to their latest versions. It builds on top of #2 and should be reviewed/merged after it.
./gradlew wrapper --gradle-version 7.3.3 --distribution-type allcommand.7.1.0. I was a little reluctant to go to the latest version, but since there weren't any build errors specific to this version, I figured this way we'd test everything only once. I am open to suggestions if there is any preference for going with another version.30. This is a required change for the Android Gradle Plugin update and would have been necessary even if we upgraded to4.2.2. (latest version before7.0) It also drops thebuildToolsVersionwhich has been deprecated and no longer necessary.I have some reservations about upgrading the target sdk due to my unfamiliarity with the project as the change needs to be tested thoroughly. I am hoping the reviewers can help me with this.
There is a good chance we'd want to test its integration to the Tumblr app before we approve this PR, which is completely fine by me. I'll keep opening PRs that build on top of each other and when we get to publishing the library artifacts, we can test the integration. This approach should still make it easier to review the PRs & follow along the changes. 🤞