Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes androidx import, lint & powermock reflection issues #2

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

oguzkocer
Copy link
Collaborator

This PR is a collection of minor fixes to get the project in a state where ./gradlew build is successful. This will help prepare the project for further updates such as Gradle/AGP upgrade, Buildkite integration and publishing to S3 support.

Copy link
Collaborator

@obsantos obsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. We will have to revisit the unit tests here because we have plans to move away from Powermock on the main repo, but we can definitely do that on future PRs

@oguzkocer oguzkocer mentioned this pull request Feb 10, 2022
@oguzkocer oguzkocer merged commit 78cb663 into master Feb 11, 2022
@oguzkocer oguzkocer deleted the fix/lint-and-powermock-errors branch February 11, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants