Correctly handle inheritance with ServiceAccounts #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byxorna
changed the title
alex-laties
approved these changes
Jan 24, 2020
komapa
approved these changes
Jan 24, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
I found a but that would cause an injection config that uses inheritance to not correctly inherit the ServiceAccountName. Additionally, I accidentally would skip injecting the serviceAccount if the pod admission request was not empty, but this is bad because the default ServiceAccountName is called
"default".Testing Steps
make test)Reviewers
Required reviewers: @byxorna @defect @komapa @tumblr/k8s
Request reviews from other people you want to review this PR in the "Reviewers" section on the right.