make sure we remove any volumeMounts that were precreated when inject… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a serviceAccount
…any new VolumeMounts
byxorna
commented
Jan 24, 2020
| @@ -230,27 +231,6 @@ func addContainers(target, added []corev1.Container, basePath string) (patch []p | |||
| return patch | |||
| } | |||
|
|
|||
| func addInitContainers(target, added []corev1.Container, basePath string) (patch []patchOperation) { | |||
There was a problem hiding this comment.
This was no longer used, due to a previous refactor.
alex-laties
approved these changes
Jan 24, 2020
komapa
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing a serviceAccount
What and why?
I missed one edge case in #39 - any containers that exist in the admission requested pod before we inject a serviceAccount will already have had any VolumeMounts for the serviceaccount's token created, when
automountServiceAccountToken:true. This is a bit annoying, and causes users of ServiceAccount injections to have original containers continue to use thedefault-token-*mount, whereas injected containers use the correct${serviceAccountName}-token-*mount that is added by the ServiceAccountController after processing the MWAC injection.Testing Steps
make test)Reviewers
Required reviewers:
@byxornaRequest reviews from other people you want to review this PR in the "Reviewers" section on the right.