Add support for concurrent send/recv apis for tun device #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-mariappan-ramasamy
force-pushed
the
async-send-recv-apis
branch
from
d7eec71
to
163c613
Compare
xmh0511
reviewed
Jul 23, 2024
Tokio supports async api's for UDP socket which does not need `&mut self` pub async fn recv(&self, buf: &mut [u8]) -> Result<usize> pub async fn send(&self, buf: &[u8]) -> Result<usize> This makes it pretty easy to call it concurrently, without adding Arc<Mutex<T>> to UdpSocket. This PR tries to add support for similar apis to tun device. In this commit, only sync version of recv/send apis are added. Async version will be added in further commit. Reference: https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.recv https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.send
kp-mariappan-ramasamy
force-pushed
the
async-send-recv-apis
branch
2 times, most recently
from
ffc404d
to
159781d
Compare
kp-mariappan-ramasamy
force-pushed
the
async-send-recv-apis
branch
from
159781d
to
7e6c4bc
Compare
|
Thanks @xmh0511 for the review. I have addressed the comments and tested in linux and android platform. Can you please take a look again ? |
Everything sounds good to me, I will merge this PR after checking passed. |
Since unix uses AsyncFd from tokio, it is easier to wait for Ready on AsyncFd and call sync send/recv apis This commit does not take care of windows, which is not as straight-forward as posix variants.
kp-mariappan-ramasamy
force-pushed
the
async-send-recv-apis
branch
from
7e6c4bc
to
082025d
Compare
kp-mariappan-ramasamy
added a commit
to kp-mariappan-ramasamy/rust-tun
that referenced
this pull request
Jul 23, 2024
When adding support for async send/recv apis in tun2proxy#87, ios and android builds got broken with following error error[E0433]: failed to resolve: use of undeclared crate or module `io` Root cause: Both ios and android platform code did not import std::io::self which caused it to fail. Updated it to use full path to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokio supports async api's for UDP socket which does not need
&mut selfThis makes it pretty easy to call it concurrently, without adding Arc<Mutex> to UdpSocket.
This PR tries to add support for similar apis to tun device in
tun2crate.Reference:
https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.recv
https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.send
This PR does not take care of windows, which is not as straight-forward as posix variants.