Fix ios and android builds #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seams good. but please remove the warnings. |
kp-mariappan-ramasamy
force-pushed
the
fix-ios-android
branch
from
6820f01
to
770f353
Compare
kp-mariappan-ramasamy
force-pushed
the
fix-ios-android
branch
3 times, most recently
from
4a610a0
to
f8d7cc1
Compare
|
OK. Please rebase it. |
When adding support for async send/recv apis in tun2proxy#87, ios and android builds got broken with following error error[E0433]: failed to resolve: use of undeclared crate or module `io` Root cause: Both ios and android platform code did not import std::io::self which caused it to fail. Updated it to use full path to fix it
Used cargo ndk which makes compiling for android code smoother. https://github.com/bbqsrc/cargo-ndk
Used cargo-lipo, which helps in compiling for iOS target. https://github.com/TimNN/cargo-lipo
kp-mariappan-ramasamy
force-pushed
the
fix-ios-android
branch
from
f8d7cc1
to
d78a91b
Compare
Errors:
warning: unused imports: `ipaddr_to_sockaddr`, `sockaddr_union`
--> src/platform/posix/mod.rs:18:27
|
18 | pub(crate) use sockaddr::{ipaddr_to_sockaddr, sockaddr_union};
| ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: function `ipaddr_to_sockaddr` is never used
--> src/platform/posix/sockaddr.rs:63:15
|
63 | pub unsafe fn ipaddr_to_sockaddr<T>(
| ^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/platform/android/mod.rs:29:17
|
29 | Device::new(&configuration)
| ^^^^^^^^^^^^^^ help: change this to: `configuration`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/platform/ios/mod.rs:58:17
|
58 | Device::new(&configuration)
| ^^^^^^^^^^^^^^ help: change this to: `configuration`
kp-mariappan-ramasamy
force-pushed
the
fix-ios-android
branch
from
d78a91b
to
31b8efe
Compare
|
@ssrlive Rebased commits for clean history. PTAL |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support for async send/recv apis in #87 , ios and android builds got broken with following error
Root cause:
Both ios and android platform code did not import
std::io::selfwhich caused it to fail.This PR attempts to fix those issues.
Also I have added CI jobs to build Android and iOS targets, to find these issues earlier
Example of test fail without the fix:
https://github.com/kp-mariappan-ramasamy/rust-tun/actions/runs/10058442720/job/27801536723#step:4:95
https://github.com/kp-mariappan-ramasamy/rust-tun/actions/runs/10058442720/job/27801536214#step:4:110