Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #372

Merged
merged 6 commits into from
Jan 2, 2019
Merged

Dev #372

merged 6 commits into from
Jan 2, 2019

Conversation

xueruini
Copy link
Contributor

@xueruini xueruini commented Dec 9, 2018

No description provided.

thuthesis.dtx Outdated
% 论文是使用英文。
% \changes{v5.4.6}{2018/12/09}{增加选项使用英文模板。}
% \begin{macrocode}
\DeclareBoolOption{chinese}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

比较倾向于像 degree 那样,将 language 做成一个 choice

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯,我修改下。话说 tocarialchapter, tocarialchapterentry, tocarialchapterpage 几个选项怎么办?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外我是 rebase 还是直接增加 commits 呀?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯,我修改下。话说 tocarialchapter, tocarialchapterentry, tocarialchapterpage 几个选项怎么办?

当时这几个是为了应急,后来也不知道用的多不多。这个没必要例会它

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外我是 rebase 还是直接增加 commits 呀?

直接 commit 吧

\newcommand\thu@setchinese{%
\xeCJKResetPunctClass
}
\newcommand\thu@setenglish{%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉好多 tricks 这些是必须要配置的么

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要是 unicode 引号 “”‘’ 会被 xeCJK 当作中文的全宽符号处理,在英文里使用的话就不太合适。

虽然英文的引号也可以用 TeX 的传统方式输入,但我觉得也应该接受 unicode 引号。

参考 CTeX-org/ctex-kit#389

\ifthu@postdoctor
\newcommand{\thu@resume@title}{个人简历、发表的学术论文与科研成果}
\else
\newcommand{\thu@resume@title}{个人简历、在学期间发表的学术论文与研究成果}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattandryc do you know the official trans for these titles?

Copy link
Contributor

@mattandryc mattandryc Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在学期间发表的学术论文与研究成果: "Resume, Publications and Research Achievements During Course of Study"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像没收到邮件

Copy link
Contributor Author

@xueruini xueruini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就只差那些章节的正确翻译了

\fi
\fi
\fi
\newcommand\thu@validate@key[1]{%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zepinglee
Copy link
Contributor

@xueruini 我感觉几个 topic 混在一起不太好,要不每个 topic 开一个 branch 然后你来 review 和 merge to master?这样就没必要开 pull request 了

@xueruini
Copy link
Contributor Author

xueruini commented Jan 2, 2019

@xueruini 我感觉几个 topic 混在一起不太好,要不每个 topic 开一个 branch 然后你来 review 和 merge to master?这样就没必要开 pull request 了

好像现在就是翻译拿不准,别的都 OK。我都看了的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants