Dont't ignore filtering by types in function getTokens. #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=========================================
+ Coverage 74.99% 75% +0.01%
=========================================
Files 153 153
Lines 10081 10079 -2
Branches 1589 1588 -1
=========================================
Hits 7560 7560
+ Misses 1965 1962 -3
- Partials 556 557 +1 |
sharwell
reviewed
Feb 27, 2019
| @@ -308,10 +308,6 @@ export class BufferedTokenStream implements TokenStream { | |||
| throw new RangeError("start " + start + " or stop " + stop + " not in 0.." + (this.tokens.length - 1)); | |||
| } | |||
|
|
|||
| if (start === 0 && stop === this.tokens.length - 1) { | |||
There was a problem hiding this comment.
📝 So this was supposed to handle the case of this method:
It looks like I messed this up a bit in a few ways. Let me add back the explicit overloads and implement this in a manner more consistent with patterns followed later in the porting work.
|
Great catch @nmarusov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand, getTokens must return filtered tokens even though the full range of indices has been passed. Now the filtering is skipped.