Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont't ignore filtering by types in function getTokens. #409

Closed
wants to merge 1 commit into from
Closed

Dont't ignore filtering by types in function getTokens. #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/BufferedTokenStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,6 @@ export class BufferedTokenStream implements TokenStream {
throw new RangeError("start " + start + " or stop " + stop + " not in 0.." + (this.tokens.length - 1));
}

if (start === 0 && stop === this.tokens.length - 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 So this was supposed to handle the case of this method:

https://github.com/tunnelvisionlabs/antlr4/blob/be017394a160f85d201f55aac962090e30f1b4b6/runtime/Java/src/org/antlr/v4/runtime/BufferedTokenStream.java#L267

It looks like I messed this up a bit in a few ways. Let me add back the explicit overloads and implement this in a manner more consistent with patterns followed later in the porting work.

return this.tokens;
}

if (start > stop) {
return [];
}
Expand Down