[pull] master from teambit:master #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
|
There was an error handling pipeline event 86dbfe17-2dec-4304-a27a-5c3ccd15c859. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| // create wrapper function | ||
| const wrapper = Module.wrap(content); | ||
|
|
||
| const invalidationKey = crypto.createHash('sha1').update(content, 'utf8').digest('hex'); |
There was a problem hiding this comment.
opt.semgrep.node_sha1: SHA1 is a a weak hash which is known to have collision. Use a strong hashing function.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
…+ type schema node signature serialization fix (#9474)
…9476) This is helpful when all we want is to notify the watchers that a new event has been written to the filesystem. It doesn't require the watchers to register to GotEventSlot. The watchers always listen to this onNotifySSE event, and once they get it, they simply send a server-send-event to the clients.
In some cases, when tagging or snapping with `--build` flag, the buildStatus remain `pending`, instead of `succeed`. This is a regression caused by #9437. It happens for example when tagging/snapping aspects. It's happening because the `ConsumerComponent instance inside the harmony component is different than the one originally created. Although the harmony component is created by the legacy, but in case the `Workspace` aspect already had this component in the cache, it won't use the provided legacy, but create a new one. As a result, the buildStatus was set to one instance of ConsumerComponent and another instance was saved into the filesystem. This PR fixes it by making sure it's using the same instance of `ConsumerComponent`.
…o be dev dependencies (#9479)
…of add-dependencies-graph (#9475)
…that Ramda is removed (#9485)
#9487) Also, limit the concurrency of scopes to fetch to 30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )