Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement alpha provider identity support #1

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

turkenh
Copy link
Owner

@turkenh turkenh commented Nov 1, 2023

Description of your changes

Port original PR upbound#69 to refactored new structure of the relevant codebase

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Deploy provider-helm with and without the --enable-provider-identity flag and ensure the deployment is as expected in both cases.

@turkenh turkenh requested a review from phisco November 1, 2023 14:30
@turkenh turkenh changed the title Add support for alpha provider identity support Reimplement alpha provider identity support Nov 2, 2023
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Collaborator

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@turkenh turkenh merged commit 954bedd into sync-upstream-master Nov 2, 2023
15 of 20 checks passed
turkenh added a commit that referenced this pull request Nov 2, 2023
Reimplement alpha provider identity support
turkenh pushed a commit that referenced this pull request Oct 21, 2024
…puts

refactor: make crossplaneImage less special
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants