-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for alpha provider identity support #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hasheddan! Left a couple of comments/questions below 👍
cmd/crossplane/core/core.go
Outdated
// and should be removed when a runtime interface is introduced upstream. | ||
// See https://github.com/crossplane/crossplane/issues/2671 for more | ||
// information. | ||
EnableProviderIdentity bool `group:"Alpha Features" help:"Enable support for Provider identity."` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EnableProviderIdentity bool `group:"Alpha Features" help:"Enable support for Provider identity."` | |
EnableProviderIdentity bool `group:"Alpha Features:" help:"Enable support for Provider identity."` |
Based on formatting of the above flags 👍.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nice catch!
func buildProviderDeployment(provider *pkgmetav1.Provider, revision v1.PackageRevision, cc *v1alpha1.ControllerConfig, namespace string, pullSecrets []corev1.LocalObjectReference, providerIdentity bool) (*corev1.ServiceAccount, *appsv1.Deployment, *corev1.Service) { // nolint:gocyclo | ||
s := &corev1.ServiceAccount{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth expanding the signature with functional options here? I realize this is "temporary", however it seems like we could see other non-default options being passed in the future.
Also, maybe this doesn't matter as much if we go down the PRI path, I just see the super long function signature and wonder if that's necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this weren't the structure upstream I would definitely agree. However, introducing functional arguments for this "temporary" functionality feels like it isn't worth the increased diff. Agreed it is gross and I look forward to removing :)
8cd06d7
to
1ce6912
Compare
@hasheddan we merged #68, so we'll need to rebase this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @phisco! I wanted that one to go in first 👍🏻
8a3e9c0
to
11433ae
Compare
Adds support for enabling provider identity. This feature is unlikely to graduate from alpha, and will likely be replaced by an implementation of the runtime interface. It is disabled by default and is only functional when running on Upbound. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
11433ae
to
e9d31c7
Compare
Add support for alpha provider identity support
Add support for alpha provider identity support
- Port original PR upbound/crossplane#69 to refactored new structure of the relevant codebase Signed-off-by: Hasan Turken <turkenh@gmail.com>
Description of your changes
Adds support for enabling provider identity. This feature is unlikely to graduate from alpha, and will likely be replaced by an implementation of the runtime interface. It is disabled by default and is only functional when running on Upbound.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Verified that we are mounting successfully when the
--enable-provider-identity
flag is set and that we are not when it is not.