Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): fix floating point decimal precision #750

Merged
merged 8 commits into from
Aug 2, 2021

Conversation

fengT-T
Copy link
Contributor

@fengT-T fengT-T commented Aug 1, 2021

fix floating point decimal precision
修复 n-slider 的浮点数小数精度丢失

issue
close #751

@vercel
Copy link

vercel bot commented Aug 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/4KpDKvJjpBrHN4kA898sMnkLN7fL
✅ Preview: https://naive-ui-git-fork-fengt-t-main-tusimple.vercel.app

src/slider/src/Slider.tsx Outdated Show resolved Hide resolved
src/slider/src/Slider.tsx Outdated Show resolved Hide resolved
src/slider/src/Slider.tsx Outdated Show resolved Hide resolved
CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
@Talljack
Copy link
Contributor

Talljack commented Aug 2, 2021

rebase一下最新的main分支吧,很多文档的修改在里面

@fengT-T
Copy link
Contributor Author

fengT-T commented Aug 2, 2021

@Talljack 已经修改了。

CHANGELOG.en-US.md Outdated Show resolved Hide resolved
CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #750 (a2837b0) into main (a1a3535) will increase coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head a2837b0 differs from pull request most recent head da4807b. Consider uploading reports for the commit da4807b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
+ Coverage   39.58%   39.60%   +0.02%     
==========================================
  Files         507      507              
  Lines       12373    12379       +6     
  Branches     3467     3468       +1     
==========================================
+ Hits         4898     4903       +5     
  Misses       6566     6566              
- Partials      909      910       +1     
Impacted Files Coverage Δ
src/slider/src/Slider.tsx 16.97% <83.33%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a3535...da4807b. Read the comment docs.

Co-authored-by: Yugang Cao <34439652+Talljack@users.noreply.github.com>
Co-authored-by: Yugang Cao <34439652+Talljack@users.noreply.github.com>
@07akioni 07akioni merged commit 85de0ec into tusen-ai:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider Floating point decimal precision(滑块碰到浮点数小数会有精度问题)
3 participants